GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: use simdutf utf8 to utf16 instead of icu by anonrig · Pull Request #46471 · nodejs/node

Conversation

@anonrig

@anonrig anonrig commented Feb 2, 2023

Copy link
Copy Markdown
Member

Replacing one of the crucial parts with simdutf for faster performance.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@anonrig anonrig added the performance Issues and PRs related to the performance of Node.js. label Feb 2, 2023
@anonrig
anonrig requested a review from addaleax February 2, 2023 17:52
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 2, 2023
@anonrig anonrig added commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. and removed c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 2, 2023
@anonrig

anonrig commented Feb 2, 2023

Copy link
Copy Markdown
Member Author

cc @nodejs/cpp-reviewers
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 2, 2023
anonrig
anonrig commented Feb 2, 2023
View reviewed changes
Comment thread src/inspector/main_thread_interface.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
anonrig added 2 commits February 2, 2023 13:16
@anonrig
src: use simdutf utf8 to utf16 instead of icu
149a3d1
@anonrig
src: use string_view instead of std::string&
56e4773
@anonrig
anonrig force-pushed the improve-utf16-conversion branch from 3712861 to 56e4773 Compare February 2, 2023 18:17
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 2, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49317/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Feb 2, 2023
View reviewed changes
@anonrig anonrig added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Feb 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49320/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS
RafaelGSS approved these changes Feb 2, 2023
View reviewed changes
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 3, 2023
targos
targos reviewed Feb 3, 2023
View reviewed changes
Comment thread src/inspector/main_thread_interface.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
@targos targos mentioned this pull request Feb 3, 2023
build: add GitHub Action for coverage with --without-intl #37954
Closed
@anonrig
src: remove unused includes from main thread
313219a
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 3, 2023
@anonrig

anonrig commented Feb 3, 2023

Copy link
Copy Markdown
Member Author

Appreciate re-reviews @targos @RafaelGSS @addaleax
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49339/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Feb 3, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Feb 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49372/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Feb 4, 2023
View reviewed changes
@anonrig

anonrig commented Feb 4, 2023

Copy link
Copy Markdown
Member Author

Is there a bug on this pull request, or are these flaky tests?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Feb 5, 2023
CI Reliability 2023-02-05 nodejs/reliability#495
Open
CI Reliability 2023-02-06 nodejs/reliability#497
Open
@nodejs-github-bot

nodejs-github-bot commented Feb 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49436/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 6, 2023

Copy link
Copy Markdown
Collaborator

Landed in 6a60ed8...8a4b1c9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot closed this Feb 6, 2023
nodejs-github-bot pushed a commit that referenced this pull request Feb 6, 2023
@anonrig @nodejs-github-bot
src: use simdutf utf8 to utf16 instead of icu
cf60b1e 
PR-URL: #46471
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Feb 6, 2023
@anonrig @nodejs-github-bot
src: use string_view instead of std::string&
a086363 
PR-URL: #46471
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Feb 6, 2023
@anonrig @nodejs-github-bot
src: remove unused includes from main thread
8a4b1c9 
PR-URL: #46471
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@anonrig
anonrig deleted the improve-utf16-conversion branch February 6, 2023 17:47
@github-actions github-actions Bot mentioned this pull request Feb 7, 2023
CI Reliability 2023-02-07 nodejs/reliability#498
Open
18 tasks
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@anonrig @MylesBorins
src: use simdutf utf8 to utf16 instead of icu
f35f6d2 
PR-URL: #46471
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@anonrig @MylesBorins
src: use string_view instead of std::string&
60c2a86 
PR-URL: #46471
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@anonrig @MylesBorins
src: remove unused includes from main thread
f72f643 
PR-URL: #46471
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
v19.7.0 proposal #46725
Merged
@StefanStojanovic StefanStojanovic mentioned this pull request Feb 22, 2023
Add Windows on ARM support simdutf/simdutf#216
Closed
StefanStojanovic added a commit to JaneaSystems/node that referenced this pull request Feb 22, 2023
@StefanStojanovic
win,src: revert simdutf to icu for win arm64
b7fbc9b 
Many tests started failing on ARM64 Windows after migrating from icu to
simdutf. This change reverts those changes for the problematic platform.

Refs: nodejs#46471
Refs: nodejs#46472
Refs: nodejs#46548
Refs: simdutf/simdutf#216
@StefanStojanovic StefanStojanovic mentioned this pull request Feb 22, 2023
win,src: revert simdutf to icu for win arm64 #46780
Closed
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@anonrig @danielleadams
src: use simdutf utf8 to utf16 instead of icu
f1c7700 
PR-URL: #46471
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@anonrig @danielleadams
src: use string_view instead of std::string&
b9ca302 
PR-URL: #46471
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@anonrig @danielleadams
src: remove unused includes from main thread
b3b3b33 
PR-URL: #46471
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
v18.16.0 release proposal #47502
Merged
codebytere added a commit to electron/electron that referenced this pull request Apr 15, 2023
@codebytere
fix: add simdutf dep to src/inspector BUILD.gn
5305acb 
- nodejs/node#46471
- nodejs/node#46472
codebytere added a commit to electron/electron that referenced this pull request Apr 16, 2023
@codebytere
fix: add simdutf dep to src/inspector BUILD.gn
b21ca56 
- nodejs/node#46471
- nodejs/node#46472
codebytere added a commit to electron/electron that referenced this pull request Apr 17, 2023
@codebytere
fix: add simdutf dep to src/inspector BUILD.gn
8096620 
- nodejs/node#46471
- nodejs/node#46472
codebytere added a commit to electron/electron that referenced this pull request Apr 18, 2023
@electron-roller @codebytere
chore: bump node to v18.16.0 (main) (#37973)
de192c2 
* chore: bump node in DEPS to v18.16.0

* build,test: add proper support for IBM i

nodejs/node#46739

* lib: enforce use of trailing commas

nodejs/node#46881

* src: add initial support for single executable applications

nodejs/node#45038

* lib: do not crash using workers with disabled shared array buffers

nodejs/node#41023

* src: remove shadowed variable in OptionsParser::Parse

nodejs/node#46672

* src: allow embedder control of code generation policy

nodejs/node#46368

* src: allow optional Isolate termination in node::Stop()

nodejs/node#46583

* lib: fix BroadcastChannel initialization location

nodejs/node#46864

* chore: fixup patch indices

* chore: sync filenames.json

* fix: add simdutf dep to src/inspector BUILD.gn

- nodejs/node#46471
- nodejs/node#46472

* deps: replace url parser with Ada

nodejs/node#46410

* tls: support automatic DHE

nodejs/node#46978

* fixup! src: add initial support for single executable applications

* http: unify header treatment

nodejs/node#46528

* fix: libc++ buffer overflow in string_view ctor

nodejs/node#46410

* test: include strace openat test

nodejs/node#46150

* fixup! fixup! src: add initial support for single executable applications

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis left review comments
@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
+1 more reviewer
@targos targos targos left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@anonrig @nodejs-github-bot @bnoordhuis @jasnell @addaleax @targos @RafaelGSS
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.