GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: document how to use the tls.DEFAULT_CIPHERS by andreas-ibm · Pull Request #46482 · nodejs/node

Conversation

@andreas-ibm

@andreas-ibm andreas-ibm commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

The tls.DEFAULT_CIPHERS var already exists, this change shows how to use it.

Fixes: #46462

I have attempted to keep my changes in style with the rest, I tried finding the Style Guide but the link just sent me back to the top-level README.md so I couldn't find it.

I hope this is helpful!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@andreas-ibm
doc: document how to use the tls.DEFAULT_CIPHERS
c951d3d 
The DEFAULT_CIPHERS already exists, this change shows how to use it.

Fixes: nodejs#46462
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. tls Issues and PRs related to the tls subsystem. labels Feb 3, 2023
@andreas-ibm

andreas-ibm commented Feb 3, 2023

Copy link
Copy Markdown
Contributor Author

Would it be cheeky to request this goes into v18 too? I don't know how that's done if possible...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau added the lts-watch-v18.x label Feb 3, 2023
@richardlau

richardlau commented Feb 3, 2023

Copy link
Copy Markdown
Member

cc @nodejs/crypto

Would it be cheeky to request this goes into v18 too? I don't know how that's done if possible...

Since Node.js 18 is in active maintenance it should eventually get semver-minor and semver-patch updates once they've gone out in a current release. I'll add the watch label anyway, as it is an extra thing checked when we prepare releases.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andreas-ibm

andreas-ibm commented Feb 3, 2023

Copy link
Copy Markdown
Contributor Author

D'oh, forgot the linter gets run in inlined code!
Will fix!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
andreas-ibm added 2 commits February 3, 2023 13:20
@andreas-ibm
doc: fix lint errors and warnings
e2c0b05
@andreas-ibm
doc: remove copy-paste typo
8167f89
lpinca
lpinca approved these changes Feb 3, 2023
View reviewed changes
@lpinca lpinca added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Feb 3, 2023
VoltrexKeyva
VoltrexKeyva reviewed Feb 5, 2023
View reviewed changes
Comment thread doc/api/tls.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@andreas-ibm @VoltrexKeyva
Update doc/api/tls.md
0c6719e 
Remove extraneous quotes

Co-authored-by: Mohammed Keyvanzadeh <[email protected]>
aymen94
aymen94 approved these changes Feb 6, 2023
View reviewed changes
jasnell
jasnell approved these changes Feb 7, 2023
View reviewed changes
@andreas-ibm

andreas-ibm commented Feb 23, 2023

Copy link
Copy Markdown
Contributor Author

Is there anything I need to do to get this merged?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 23, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 23, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 42be7f6 into nodejs:main Feb 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in 42be7f6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andreas-ibm
andreas-ibm deleted the dre/doc-ciphers branch February 23, 2023 16:38
targos pushed a commit that referenced this pull request Mar 13, 2023
@andreas-ibm @targos
doc: document how to use the tls.DEFAULT_CIPHERS
60d1a48 
The DEFAULT_CIPHERS already exists, this change shows how to use it.

Fixes: #46462
PR-URL: #46482
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
v19.8.0 release proposal #47087
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@andreas-ibm @danielleadams
doc: document how to use the tls.DEFAULT_CIPHERS
7e08ca1 
The DEFAULT_CIPHERS already exists, this change shows how to use it.

Fixes: #46462
PR-URL: #46482
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
v18.16.0 release proposal #47502
Merged
@pimterry pimterry mentioned this pull request Aug 29, 2023
Clarify the documentation for TLS cipher configuration & defaults #41061
Closed
@targos targos added backported-to-v18.x and removed lts-watch-v18.x labels Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
+2 more reviewers
@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Externalise tls.DEFAULT_CIPHERS please!

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@andreas-ibm @richardlau @nodejs-github-bot @jasnell @lpinca @aymen94 @VoltrexKeyva @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.