GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: avoid leaking snapshot fp on error by tniessen · Pull Request #46497 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Feb 4, 2023

Copy link
Copy Markdown
Member

Call fclose() on the snapshot file regardless of whether reading the snapshot data succeeded.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@tniessen
src: avoid leaking snapshot fp on error
3a1240a 
Call fclose() on the snapshot file regardless of whether reading the
snapshot data succeeded.
@tniessen
tniessen requested a review from joyeecheung February 4, 2023 14:08
@nodejs-github-bot

nodejs-github-bot commented Feb 4, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 4, 2023
addaleax
addaleax approved these changes Feb 4, 2023
View reviewed changes
joyeecheung
joyeecheung approved these changes Feb 4, 2023
View reviewed changes
lpinca
lpinca approved these changes Feb 4, 2023
View reviewed changes
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 4, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 4, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
jasnell
jasnell approved these changes Feb 4, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Feb 5, 2023
CI Reliability 2023-02-05 nodejs/reliability#495
Open
22 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@tniessen tniessen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Feb 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49409/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Feb 6, 2023
CI Reliability 2023-02-06 nodejs/reliability#497
Open
19 tasks
RaisinTen
RaisinTen approved these changes Feb 6, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Feb 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49445/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen tniessen added the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 6, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 3344bb7 into nodejs:main Feb 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 6, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3344bb7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen tniessen mentioned this pull request Feb 6, 2023
src: allow blobs in addition to FILE*s in embedder snapshot API #46491
Merged
@github-actions github-actions Bot mentioned this pull request Feb 7, 2023
CI Reliability 2023-02-07 nodejs/reliability#498
Open
18 tasks
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@tniessen @MylesBorins
src: avoid leaking snapshot fp on error
3c5db8f 
Call fclose() on the snapshot file regardless of whether reading the
snapshot data succeeded.

PR-URL: #46497
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
v19.7.0 proposal #46725
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@tniessen @danielleadams
src: avoid leaking snapshot fp on error
483cd19 
Call fclose() on the snapshot file regardless of whether reading the
snapshot data succeeded.

PR-URL: #46497
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
v18.16.0 release proposal #47502
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@tniessen @nodejs-github-bot @jasnell @addaleax @lpinca @joyeecheung @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.