GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — timers: cleanup no-longer relevant TODOs in timers/promises by jasnell · Pull Request #46499 · nodejs/node

Conversation

jasnell commented Feb 4, 2023

Copy link

Copy Markdown

Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          timers: cleanup no-longer relevant TODOs in timers/promises

d33487d

nodejs-github-bot added needs-ci

PRs that need a full CI run.

timers Issues and PRs related to timers, setImmediate(), setInterval(), and setTimeout(). labels

Feb 4, 2023

MoLow approved these changes

Feb 4, 2023

View reviewed changes

jasnell added fast-track

PRs proposed for a shorter-than-standard waiting period before landing.

request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels

Feb 4, 2023

github-actions Bot commented Feb 4, 2023

Copy link

Copy Markdown

Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

MoLow, anonrig, and lpinca reacted with thumbs up emoji

All reactions

👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Feb 4, 2023

nodejs-github-bot commented Feb 4, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49378/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

anonrig approved these changes

Feb 4, 2023

View reviewed changes

nodejs-github-bot commented Feb 4, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49381/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Feb 4, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49382/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Feb 5, 2023

CI Reliability 2023-02-05 nodejs/reliability#495

Open

22 tasks

nodejs-github-bot commented Feb 5, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49390/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lpinca approved these changes

Feb 5, 2023

View reviewed changes

MoLow added author ready

PRs with CI started, the required approvals, and no outstanding review comments.

commit-queue PRs queued for automated landing through the Commit Queue. labels

Feb 5, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Feb 5, 2023

nodejs-github-bot merged commit 06b28fb into nodejs:main

Feb 5, 2023

nodejs-github-bot commented Feb 5, 2023

Copy link

Copy Markdown

Collaborator

Landed in 06b28fb

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Feb 6, 2023

CI Reliability 2023-02-06 nodejs/reliability#497

Open

CI Reliability 2023-02-07 nodejs/reliability#498

Open

MylesBorins pushed a commit that referenced this pull request

Feb 18, 2023


          timers: cleanup no-longer relevant TODOs in timers/promises

6f24f06

PR-URL: #46499
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

MylesBorins mentioned this pull request

Feb 19, 2023

v19.7.0 proposal #46725

Merged

danielleadams pushed a commit that referenced this pull request

Apr 11, 2023


          timers: cleanup no-longer relevant TODOs in timers/promises

9b58857

PR-URL: #46499
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

danielleadams mentioned this pull request

Apr 11, 2023

v18.16.0 release proposal #47502

Merged

Reviewers

lpinca

lpinca approved these changes

anonrig

anonrig approved these changes

MoLow

MoLow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

fast-track

PRs proposed for a shorter-than-standard waiting period before landing.

needs-ci

PRs that need a full CI run.

timers

Issues and PRs related to timers, setImmediate(), setInterval(), and setTimeout().

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.