GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: handle wasm out of bound in osx will raise SIGBUS correctly by HerrCai0907 · Pull Request #46561 · nodejs/node

Conversation

@HerrCai0907

@HerrCai0907 HerrCai0907 commented Feb 8, 2023

Copy link
Copy Markdown
Contributor

fix: #46559
OSX will raise both SIGBUS and SIGSEGV when out of bound memory visit, This commit set sigaction in OSX for two signals to handle this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss and unilynx reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot

nodejs-github-bot commented Feb 8, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 8, 2023
addaleax
addaleax approved these changes Feb 8, 2023
View reviewed changes
Comment thread src/node.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

addaleax
addaleax approved these changes Feb 8, 2023
View reviewed changes
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 8, 2023
@github-actions github-actions Bot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Feb 8, 2023
@github-actions

github-actions Bot commented Feb 8, 2023

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✖  Jenkins credentials invalid
https://github.com/nodejs/node/actions/runs/4125736345
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell
jasnell approved these changes Feb 9, 2023
View reviewed changes
RaisinTen
RaisinTen approved these changes Feb 9, 2023
View reviewed changes
JungMinu
JungMinu approved these changes Feb 9, 2023
View reviewed changes
@HerrCai0907

HerrCai0907 commented Feb 11, 2023

Copy link
Copy Markdown
Contributor Author

Is it possible to re-run the CI?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@legendecas

legendecas commented Feb 13, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

CI has been locked down for Feb 14 security releases.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 2, 2023
@mhdawson

mhdawson commented Mar 2, 2023

Copy link
Copy Markdown
Member

Requested new CI

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50172/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Mar 3, 2023
CI Reliability 2023-03-03 nodejs/reliability#512
Open
CI Reliability 2023-03-04 nodejs/reliability#513
Open
CI Reliability 2023-03-05 nodejs/reliability#514
Open
CI Reliability 2023-03-06 nodejs/reliability#515
Open
CI Reliability 2023-03-07 nodejs/reliability#516
Open
CI Reliability 2023-03-08 nodejs/reliability#517
Open
@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. labels Mar 9, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 9, 2023
This was referenced Mar 10, 2023
CI Reliability 2023-03-10 nodejs/reliability#519
Open
CI Reliability 2023-03-11 nodejs/reliability#520
Open
CI Reliability 2023-03-12 nodejs/reliability#521
Open
@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52193/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Jun 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52201/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Jun 11, 2023
CI Reliability 2023-06-11 nodejs/reliability#590
Open
CI Reliability 2023-06-12 nodejs/reliability#591
Open
@nodejs-github-bot

nodejs-github-bot commented Jun 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52216/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@HerrCai0907

HerrCai0907 commented Jun 12, 2023

Copy link
Copy Markdown
Contributor Author

Could it land now?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RaisinTen RaisinTen added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Jun 12, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Jun 12, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 12, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/46561
✔  Done loading data for nodejs/node/pull/46561
----------------------------------- PR info ------------------------------------
Title      src: handle wasm out of bound in osx will raise SIGBUS correctly (#46561)
Author     Congcong Cai  (@HerrCai0907, first-time contributor)
Branch     HerrCai0907:fix/sigbus-in-mac-wasm -> nodejs:main
Labels     c++, author ready, commit-queue-squash
Commits    4
 - src: handle wasm out of bound in osx will raise SIGBUS correctly
 - format
 - add TODO mark
 - Update test/parallel/test-wasm-memory-out-of-bound.js
Committers 2
 - Congcong Cai 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/46561
Fixes: https://github.com/nodejs/node/issues/46559
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Darshan Sen 
Reviewed-By: Minwoo Jung 
Reviewed-By: Michael Dawson 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46561
Fixes: https://github.com/nodejs/node/issues/46559
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Darshan Sen 
Reviewed-By: Minwoo Jung 
Reviewed-By: Michael Dawson 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - Update test/parallel/test-wasm-memory-out-of-bound.js
   ℹ  This PR was created on Wed, 08 Feb 2023 09:50:45 GMT
   ✔  Approvals: 5
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/46561#pullrequestreview-1289424314
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/46561#pullrequestreview-1290258481
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/46561#pullrequestreview-1290656679
   ✔  - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/46561#pullrequestreview-1291233080
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/46561#pullrequestreview-1457624085
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-06-12T02:27:52Z: https://ci.nodejs.org/job/node-test-pull-request/52216/
- Querying data for job/node-test-pull-request/52216/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5244996345
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RaisinTen
RaisinTen approved these changes Jun 12, 2023
View reviewed changes
@RaisinTen RaisinTen added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Jun 12, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 12, 2023
@nodejs-github-bot
nodejs-github-bot merged commit ed92b1f into nodejs:main Jun 12, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 12, 2023

Copy link
Copy Markdown
Collaborator

Landed in ed92b1f

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request Jun 13, 2023
CI Reliability 2023-06-13 nodejs/reliability#592
Open
22 tasks
@HerrCai0907
HerrCai0907 deleted the fix/sigbus-in-mac-wasm branch June 13, 2023 07:10
This was referenced Jun 14, 2023
CI Reliability 2023-06-14 nodejs/reliability#593
Open
CI Reliability 2023-06-15 nodejs/reliability#594
Open
@github-actions github-actions Bot mentioned this pull request Jun 21, 2023
CI Reliability 2023-06-21 nodejs/reliability#595
Open
29 tasks
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@HerrCai0907 @RafaelGSS
src: handle wasm out of bound in osx will raise SIGBUS correctly
6591826
fix: #46559
OSX will raise both SIGBUS and SIGSEGV when out of bound memory visit,
This commit set sigaction in OSX for two signals to handle this.

PR-URL: #46561
Fixes: #46559
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@HerrCai0907 @Ceres6
src: handle wasm out of bound in osx will raise SIGBUS correctly
140f17b
fix: nodejs#46559
OSX will raise both SIGBUS and SIGSEGV when out of bound memory visit,
This commit set sigaction in OSX for two signals to handle this.

PR-URL: nodejs#46561
Fixes: nodejs#46559
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@HerrCai0907 @Ceres6
src: handle wasm out of bound in osx will raise SIGBUS correctly
ad17252
fix: nodejs#46559
OSX will raise both SIGBUS and SIGSEGV when out of bound memory visit,
This commit set sigaction in OSX for two signals to handle this.

PR-URL: nodejs#46561
Fixes: nodejs#46559
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 7, 2023
@HerrCai0907 @ruyadorno
src: handle wasm out of bound in osx will raise SIGBUS correctly
cb3abcb
fix: #46559
OSX will raise both SIGBUS and SIGSEGV when out of bound memory visit,
This commit set sigaction in OSX for two signals to handle this.

PR-URL: #46561
Fixes: #46559
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 8, 2023
v18.18.0 proposal #49220
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@HerrCai0907 @ruyadorno
src: handle wasm out of bound in osx will raise SIGBUS correctly
6c72622
fix: #46559
OSX will raise both SIGBUS and SIGSEGV when out of bound memory visit,
This commit set sigaction in OSX for two signals to handle this.

PR-URL: #46561
Fixes: #46559
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@JungMinu JungMinu JungMinu approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash PRs the Commit Queue should land as one squashed commit.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

run wasm out of memory in mac causes node crash due to SIGBUS

Uh oh!

There was an error while loading. Please reload this page.

12 participants

@HerrCai0907 @nodejs-github-bot @legendecas @mhdawson @Changqing-JING @jasnell @addaleax @JungMinu @RaisinTen @bnoordhuis @richardlau @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.