GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: fix negative nodeTiming milestone values by legendecas · Pull Request #46588 · nodejs/node

Conversation

@legendecas

@legendecas legendecas commented Feb 9, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Although the performance.timeOrigin is a Web API, Node.js specific extension performance.nodeTiming exposes the process performance milestones in the main thread and the worker threads. In order to avoid exposing negative values in performance.nodeTiming, set the performance.timeOrigin to the start time of the process both in the main thread and worker threads.

Refs: #43781
Fixes #45958, with regression test cases.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and ikhtearalamshawonmollah54321 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 9, 2023
@legendecas legendecas added dont-land-on-v14.x labels Feb 9, 2023
@legendecas

legendecas commented Feb 9, 2023

Copy link
Copy Markdown
Member Author

#43781 didn't land on v14.x and v16.x, so this fix doesn't need to land on v14.x and v16.x too.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax reviewed Feb 9, 2023
View reviewed changes
Comment thread src/env.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@legendecas
src: fix negative nodeTiming milestone values
6760c9a
@legendecas
legendecas force-pushed the perf_hooks/time_origin branch from b318df3 to 6760c9a Compare February 16, 2023 16:55
jasnell
jasnell approved these changes Feb 20, 2023
View reviewed changes
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 20, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49761/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Feb 21, 2023
CI Reliability 2023-02-21 nodejs/reliability#502
Open
26 tasks
@nodejs-github-bot

nodejs-github-bot commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49969/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Feb 25, 2023
CI Reliability 2023-02-25 nodejs/reliability#506
Open
CI Reliability 2023-02-26 nodejs/reliability#507
Open
CI Reliability 2023-02-27 nodejs/reliability#508
Open
@legendecas
fixup! fix tools/run-worker.js failure
c9e94f6
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 27, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 27, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50063/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Feb 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50065/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Feb 28, 2023
CI Reliability 2023-02-28 nodejs/reliability#509
Open
16 tasks
@nodejs-github-bot

nodejs-github-bot commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50082/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas

legendecas commented Feb 28, 2023

Copy link
Copy Markdown
Member Author

Fixed the test failure with tools/run-worker.js.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Mar 1, 2023
CI Reliability 2023-03-01 nodejs/reliability#510
Open
CI Reliability 2023-03-02 nodejs/reliability#511
Open
jasnell
jasnell approved these changes Mar 2, 2023
View reviewed changes
JungMinu
JungMinu approved these changes Mar 2, 2023
View reviewed changes
legendecas added a commit that referenced this pull request Mar 2, 2023
@legendecas
src: fix negative nodeTiming milestone values
a8c3d03 
PR-URL: #46588
Fixes: #45958
Refs: #43781
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@legendecas

legendecas commented Mar 2, 2023

Copy link
Copy Markdown
Member Author

Landed in a8c3d03
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas legendecas closed this Mar 2, 2023
@legendecas
legendecas deleted the perf_hooks/time_origin branch March 2, 2023 16:22
targos pushed a commit that referenced this pull request Mar 13, 2023
@legendecas @targos
src: fix negative nodeTiming milestone values
213efa6 
PR-URL: #46588
Fixes: #45958
Refs: #43781
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
@legendecas @targos
src: fix negative nodeTiming milestone values
6740679 
PR-URL: #46588
Fixes: #45958
Refs: #43781
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
v19.8.0 release proposal #47087
Merged
@danielleadams

danielleadams commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

@legendecas this didn't land cleanly on v18.x - do you mind opening a backport PR? Thank you
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danielleadams danielleadams added the backport-requested-v18.x label Apr 3, 2023
@legendecas legendecas added dont-land-on-v18.x and removed backport-requested-v18.x labels Apr 3, 2023
@legendecas

legendecas commented Apr 3, 2023

Copy link
Copy Markdown
Member Author

#43781 didn't land on v18.x. I'm tagging this as https://github.com/nodejs/node/labels/dont-land-on-v18.x.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@coderabbitai coderabbitai Bot mentioned this pull request Aug 10, 2026
fix: protect presenter launch reconciliation ClipboardHealth/groundcrew#361
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Aug 24, 2026
chore: release v5.12.0 Chachamaru127/claude-code-harness#334
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax left review comments
@jasnell jasnell jasnell approved these changes
@JungMinu JungMinu JungMinu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PerformanceNodeTiming of perf_hooks

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@legendecas @nodejs-github-bot @danielleadams @jasnell @addaleax @JungMinu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.