GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: fix regex strings in Python tools by Trott · Pull Request #46671 · nodejs/node

Conversation

@Trott

@Trott Trott commented Feb 15, 2023

Copy link
Copy Markdown
Member

Opening this to reland #46585 but this time with the metadata required. Sorry for the mess this has turned out to be for a simple change, @josusky. I hope it's OK that I'm doing this on your behalf. (You're still the author on the commit here.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
josusky reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Feb 15, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the python PRs and issues that require attention from people who are familiar with Python. label Feb 15, 2023
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Feb 15, 2023
@Trott Trott added fast-track PRs proposed for a shorter-than-standard waiting period before landing. and removed build Issues and PRs related to Node.js builds or CI infrastructure. v8 engine Issues and PRs related to the V8 dependency. tools Issues and PRs related to the tools directory. needs-ci PRs that need a full CI run. labels Feb 15, 2023
@github-actions

github-actions Bot commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.
RaisinTen, lpinca, gengjiawen, and debadree25 reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added build Issues and PRs related to Node.js builds or CI infrastructure. v8 engine Issues and PRs related to the V8 dependency. tools Issues and PRs related to the tools directory. needs-ci PRs that need a full CI run. labels Feb 15, 2023
RaisinTen
RaisinTen approved these changes Feb 15, 2023
View reviewed changes
lpinca
lpinca approved these changes Feb 15, 2023
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Feb 16, 2023
@gengjiawen gengjiawen added the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 16, 2023
tniessen
tniessen approved these changes Feb 16, 2023
View reviewed changes
tniessen
tniessen approved these changes Feb 16, 2023
View reviewed changes
Comment thread tools/js2c.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Feb 16, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 16, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49574/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Feb 16, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5178/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Feb 16, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5178/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Feb 17, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5178/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49807/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Feb 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49813/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@josusky @Trott
tools: fix regex strings in Python tools
af935fc 
PR-URL: nodejs#46671
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@Trott
Trott force-pushed the python-patch branch from 09c3be2 to af935fc Compare February 21, 2023 19:56
@Trott

Trott commented Feb 21, 2023

Copy link
Copy Markdown
Member Author

Landed in af935fc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit af935fc into nodejs:main Feb 21, 2023
@Trott
Trott deleted the python-patch branch February 21, 2023 19:57
This was referenced Feb 22, 2023
CI Reliability 2023-02-22 nodejs/reliability#503
Open
CI Reliability 2023-02-23 nodejs/reliability#504
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
@josusky @targos
tools: fix regex strings in Python tools
25ccaa7 
PR-URL: #46671
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
v19.8.0 release proposal #47087
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@josusky @danielleadams
tools: fix regex strings in Python tools
f80e93d 
PR-URL: #46671
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
v18.16.0 release proposal #47502
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@tniessen tniessen tniessen approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@Trott @nodejs-github-bot @lpinca @tniessen @RaisinTen @gengjiawen @aduh95 @josusky
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.