GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: allow preventing debug signal handler start by codebytere · Pull Request #46681 · nodejs/node

Conversation

@codebytere

@codebytere codebytere commented Feb 16, 2023

Copy link
Copy Markdown
Member

Electron in some cases does not want to allow certain processes to start the debug signal handler. Example usage is here.

We allow users to decide whether the --inspect, --inspect-brk, etc. flags are respected or not. When they choose this, we also ensure that SIGUSR1 signal does not initialize the main process inspector. This would allow us to remove a patch we currently float.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@codebytere
codebytere requested a review from addaleax February 16, 2023 14:18
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Feb 16, 2023
addaleax
addaleax approved these changes Feb 16, 2023
View reviewed changes

@addaleax addaleax left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you already set kNoDefaultSignalHandling in the ProcessInitializationFlags list? I’m wondering if that’s a good existing flag that could be used as well

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jasnell
jasnell approved these changes Feb 20, 2023
View reviewed changes
@codebytere @aduh95
src: allow preventing debug signal handler start
79b65fb
@aduh95
aduh95 force-pushed the optional-debug-handler branch from 1b2bfa0 to 79b65fb Compare May 11, 2024 13:13
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 11, 2024
@nodejs-github-bot

nodejs-github-bot commented May 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59097/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
format_cpp
d7592ec
@nodejs-github-bot

nodejs-github-bot commented May 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59102/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 12, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59145/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit 56b3162 into nodejs:main May 12, 2024
@aduh95

aduh95 commented May 12, 2024

Copy link
Copy Markdown
Contributor

Landed in 56b3162
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request May 12, 2024
@codebytere @targos
src: allow preventing debug signal handler start
b228db5 
PR-URL: #46681
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
v20.15.0 proposal #53486
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@codebytere @marco-ippolito
src: allow preventing debug signal handler start
9512839 
PR-URL: #46681
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@codebytere @soophoo
src: allow preventing debug signal handler start
55d82a8 
PR-URL: nodejs#46681
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Jun 24, 2024
@codebytere
src: allow preventing debug signal handler start
fe8afac 
nodejs/node#46681
codebytere added a commit to electron/electron that referenced this pull request Jun 24, 2024
@codebytere
src: allow preventing debug signal handler start
f7af605 
nodejs/node#46681
codebytere added a commit to electron/electron that referenced this pull request Jun 24, 2024
@codebytere
src: allow preventing debug signal handler start
d755579 
nodejs/node#46681
codebytere added a commit to electron/electron that referenced this pull request Jun 24, 2024
@codebytere
src: allow preventing debug signal handler start
ef05fd8 
nodejs/node#46681
codebytere added a commit to electron/electron that referenced this pull request Jun 24, 2024
@codebytere
src: allow preventing debug signal handler start
551e2a2 
nodejs/node#46681
codebytere added a commit to electron/electron that referenced this pull request Jun 27, 2024
@electron-roller @codebytere
chore: bump node to v20.15.0 (main) (#42616)
ec24b51 
* chore: bump node in DEPS to v20.15.0

* doc: Add OpenSSL errors to API docs

nodejs/node#34213

* test: crypto-rsa-dsa testing for dynamic openssl

nodejs/node#52781

* src: allow preventing debug signal handler start

nodejs/node#46681

* cli: allow running wasm in limited vmemory with --disable-wasm-trap-handler

nodejs/node#52766

* chore: fixup indices

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Jun 27, 2024
@electron-roller @codebytere
chore: bump node to v20.15.0 (32-x-y) (#42615)
ae97180 
* chore: bump node in DEPS to v20.15.0

* doc: Add OpenSSL errors to API docs

nodejs/node#34213

* test: crypto-rsa-dsa testing for dynamic openssl

nodejs/node#52781

* src: allow preventing debug signal handler start

nodejs/node#46681

* cli: allow running wasm in limited vmemory with --disable-wasm-trap-handler

nodejs/node#52766

* chore: fixup indices

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Jun 27, 2024
@electron-roller @codebytere @patchup
chore: bump node to v20.15.0 (31-x-y) (#42614)
6a058ed 
* chore: bump node in DEPS to v20.15.0

* doc: Add OpenSSL errors to API docs

nodejs/node#34213

* test: crypto-rsa-dsa testing for dynamic openssl

nodejs/node#52781

* src: allow preventing debug signal handler start

nodejs/node#46681

* cli: allow running wasm in limited vmemory with --disable-wasm-trap-handler

nodejs/node#52766

* chore: fixup patch indices

* chore: update patches

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
codebytere added a commit to electron/electron that referenced this pull request Jun 27, 2024
@electron-roller @codebytere @patchup
chore: bump node to v20.15.0 (30-x-y) (#42613)
8b06e8a 
* chore: bump node in DEPS to v20.15.0

* doc: Add OpenSSL errors to API docs

nodejs/node#34213

* test: crypto-rsa-dsa testing for dynamic openssl

nodejs/node#52781

* src: allow preventing debug signal handler start

nodejs/node#46681

* cli: allow running wasm in limited vmemory with --disable-wasm-trap-handler

nodejs/node#52766

* chore: fixup patch indices

* chore: update patches

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@codebytere @nodejs-github-bot @aduh95 @jasnell @addaleax
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.