GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add request to hold off publicising sec releases by mhdawson · Pull Request #46702 · nodejs/node

Conversation

@mhdawson

@mhdawson mhdawson commented Feb 17, 2023

Copy link
Copy Markdown
Member
  • We've often seen tweets go out early before announcement and other parts of the security release complete
  • Make an explicit ask that collorators avoid doing this by gating on the tweet from the Node.js account
  • Releasers would still be free to tweet earlier as they know when the process is complete.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot

nodejs-github-bot commented Feb 17, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mhdawson mhdawson added the tsc-agenda Issues and PRs to discuss during Technical Steering Committee meetings. label Feb 17, 2023
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Feb 17, 2023
BridgeAR
BridgeAR approved these changes Feb 17, 2023
View reviewed changes
tniessen
tniessen approved these changes Feb 17, 2023
View reviewed changes
Comment thread doc/contributing/security-release-process.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

ronag
ronag approved these changes Feb 17, 2023
View reviewed changes
mcollina
mcollina approved these changes Feb 17, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
RafaelGSS
RafaelGSS approved these changes Feb 18, 2023
View reviewed changes
marsonya
marsonya approved these changes Feb 18, 2023
View reviewed changes
gireeshpunathil
gireeshpunathil approved these changes Feb 18, 2023
View reviewed changes
aduh95
aduh95 approved these changes Feb 18, 2023
View reviewed changes
legendecas
legendecas approved these changes Feb 20, 2023
View reviewed changes
lpinca
lpinca approved these changes Feb 21, 2023
View reviewed changes
@richardlau

richardlau commented Feb 21, 2023

Copy link
Copy Markdown
Member

There's a typo in the commit message ("collorators").

Also I'm +1 for the ask but I'm not sure any collaborator reads this doc unless they are involved with a security release. I don't really have a suggestion though for where a better place to put this would be.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mhdawson mhdawson mentioned this pull request Feb 21, 2023
Node.js Technical Steering Committee (TSC) Meeting 2023-02-22 nodejs/TSC#1344
Closed
@mhdawson
doc: add request to hold off publicising sec releases
7242478
- We've often seen tweets go out early before announcement
  and other parts of the security release complete
- Make an explicit ask that collaborators avoid doing this
  by gating on the tweet from the Node.js account
- Releasers would still be free to tweet earlier as they know
  when the process is complete.

Signed-off-by: Michael Dawson <[email protected]>
@mhdawson
mhdawson force-pushed the tweet-clarification branch from 39f0a89 to 7242478 Compare February 22, 2023 14:53
@mhdawson

mhdawson commented Feb 22, 2023

Copy link
Copy Markdown
Member Author

@richardlau once we have this documented I'm going to publicise to try to make sure collaborators are aware and in cases where they are not we can point them to this doc so that we improve over time.

richardlau reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mhdawson

mhdawson commented Feb 22, 2023

Copy link
Copy Markdown
Member Author

Fixed the typo in the commit comment.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

richardlau
richardlau approved these changes Feb 22, 2023
View reviewed changes
jasnell
jasnell approved these changes Feb 22, 2023
View reviewed changes
@mhdawson mhdawson mentioned this pull request Feb 27, 2023
Node.js Technical Steering Committee (TSC) Meeting 2023-03-01 nodejs/TSC#1347
Closed
trivikr
trivikr approved these changes Feb 28, 2023
View reviewed changes
RaisinTen
RaisinTen approved these changes Feb 28, 2023
View reviewed changes
mhdawson added a commit that referenced this pull request Mar 1, 2023
@mhdawson
doc: add request to hold off publicising sec releases
7cb09f4
- We've often seen tweets go out early before announcement
  and other parts of the security release complete
- Make an explicit ask that collaborators avoid doing this
  by gating on the tweet from the Node.js account
- Releasers would still be free to tweet earlier as they know
  when the process is complete.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #46702
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@mhdawson

mhdawson commented Mar 1, 2023

Copy link
Copy Markdown
Member Author

Landed in 7cb09f4

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mhdawson mhdawson closed this Mar 1, 2023
targos pushed a commit that referenced this pull request Mar 13, 2023
@mhdawson @targos
doc: add request to hold off publicising sec releases
16d3b9a
- We've often seen tweets go out early before announcement
  and other parts of the security release complete
- Make an explicit ask that collaborators avoid doing this
  by gating on the tweet from the Node.js account
- Releasers would still be free to tweet earlier as they know
  when the process is complete.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #46702
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
@mhdawson @targos
doc: add request to hold off publicising sec releases
f9739a8
- We've often seen tweets go out early before announcement
  and other parts of the security release complete
- Make an explicit ask that collaborators avoid doing this
  by gating on the tweet from the Node.js account
- Releasers would still be free to tweet earlier as they know
  when the process is complete.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #46702
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
v19.8.0 release proposal #47087
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@mhdawson @danielleadams
doc: add request to hold off publicising sec releases
11885a7
- We've often seen tweets go out early before announcement
  and other parts of the security release complete
- Make an explicit ask that collaborators avoid doing this
  by gating on the tweet from the Node.js account
- Releasers would still be free to tweet earlier as they know
  when the process is complete.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #46702
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
v18.16.0 release proposal #47502
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@ronag ronag ronag approved these changes
@tniessen tniessen tniessen approved these changes
@richardlau richardlau richardlau approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@legendecas legendecas legendecas approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
@aduh95 aduh95 aduh95 approved these changes
@trivikr trivikr trivikr approved these changes
@marsonya marsonya marsonya approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. tsc-agenda Issues and PRs to discuss during Technical Steering Committee meetings.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

16 participants

@mhdawson @nodejs-github-bot @richardlau @mcollina @jasnell @lpinca @ronag @tniessen @gireeshpunathil @legendecas @BridgeAR @aduh95 @trivikr @marsonya @RafaelGSS @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.