GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: use newish OpenSSL feature in test-tls-dhe by tniessen · Pull Request #46708 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Feb 18, 2023

Copy link
Copy Markdown
Member

According to the comment that is being replaced here, this was not possible with the current version of OpenSSL 1.0.2 at the time the test was written. New OpenSSL versions appear to always print the length of the temporary key.

Refs: nodejs/node-v0.x-archive#8272

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tniessen
test: use newish OpenSSL feature in test-tls-dhe
a33e1c6 
According to the comment that is being replaced here, this was not
possible with the current version of OpenSSL 1.0.2 at the time the test
was written. New OpenSSL versions appear to always print the length of
the temporary key.

Refs: nodejs/node-v0.x-archive#8272
@tniessen tniessen added tls Issues and PRs related to the tls subsystem. test Issues and PRs related to Node.js core tests and test infrastructure. openssl Issues and PRs related to the OpenSSL dependency. labels Feb 18, 2023
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 18, 2023
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Feb 18, 2023
panva
panva approved these changes Feb 18, 2023
View reviewed changes
@panva panva added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Feb 18, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 18, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Feb 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49684/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Feb 18, 2023
View reviewed changes
lpinca
lpinca approved these changes Feb 18, 2023
View reviewed changes
jasnell
jasnell approved these changes Feb 20, 2023
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 20, 2023
@nodejs-github-bot
nodejs-github-bot merged commit c203921 into nodejs:main Feb 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

Landed in c203921
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Mar 13, 2023
@tniessen @targos
test: use newish OpenSSL feature in test-tls-dhe
3401315 
According to the comment that is being replaced here, this was not
possible with the current version of OpenSSL 1.0.2 at the time the test
was written. New OpenSSL versions appear to always print the length of
the temporary key.

Refs: nodejs/node-v0.x-archive#8272
PR-URL: #46708
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
v19.8.0 release proposal #47087
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@tniessen @danielleadams
test: use newish OpenSSL feature in test-tls-dhe
9311116 
According to the comment that is being replaced here, this was not
possible with the current version of OpenSSL 1.0.2 at the time the test
was written. New OpenSSL versions appear to always print the length of
the temporary key.

Refs: nodejs/node-v0.x-archive#8272
PR-URL: #46708
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
v18.16.0 release proposal #47502
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes
@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. test Issues and PRs related to Node.js core tests and test infrastructure. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@tniessen @nodejs-github-bot @panva @jasnell @lpinca @cjihrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.