GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — v18.14.2 proposal by MylesBorins · Pull Request #46724 · nodejs/node

Conversation

@MylesBorins

@MylesBorins MylesBorins commented Feb 18, 2023

Copy link
Copy Markdown
Contributor

2023-02-21, Version 18.14.2 'Hydrogen' (LTS), @MylesBorins

Notable Changes

  • [f864bef32a] - deps: upgrade npm to 9.5.0 (npm team) #46673

Commits

  • [880a65d7ff] - build: delete snapshot.blob file from the project (Juan José Arboleda) #46626
  • [cbea56efda] - deps: update undici to 5.20.0 (Node.js GitHub Bot) #46711
  • [f864bef32a] - deps: upgrade npm to 9.5.0 (npm team) #46673
  • [648041d568] - deps: upgrade npm to 9.4.0 (npm team) #46353
  • [5e1f213f3c] - deps: patch V8 to 10.2.154.26 (Michaël Zasso) #46446

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

KhafraDev, juanarbol, BethGriggs, and GaxZE reacted with heart emoji
All reactions
  • ❤️ 4 reactions
targos and others added 5 commits February 16, 2023 18:21
@targos @RafaelGSS
deps: patch V8 to 10.2.154.26
5e1f213
Refs: v8/v8@10.2.154.23...10.2.154.26
PR-URL: #46446
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@juanarbol @MylesBorins
build: delete snapshot.blob file from the project
880a65d
The `snapshot.blob` file landed while backporting
2c0f7d4
in the v18.x release line, but is not required

Fixes: #46133
PR-URL: #46626
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@npm-cli-bot @MylesBorins
deps: upgrade npm to 9.4.0
648041d
PR-URL: #46353
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@npm-cli-bot @MylesBorins
deps: upgrade npm to 9.5.0
f864bef
PR-URL: #46673
Reviewed-By: Luke Karrys <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@nodejs-github-bot @MylesBorins
deps: update undici to 5.20.0
cbea56e
PR-URL: #46711
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Feb 18, 2023
@github-actions

This comment was marked as outdated.

Sign in to view
@MylesBorins MylesBorins added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed fast-track PRs proposed for a shorter-than-standard waiting period before landing. dont-land-on-v14.x labels Feb 18, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 18, 2023 •
edited by MylesBorins
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49718/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/5184/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3124/
CITGM v18.14.1: https://ci.nodejs.org/job/citgm-smoker/3122/
CITGM v18.14.0: https://ci.nodejs.org/job/citgm-smoker/3084/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Feb 18, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5184/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Feb 18, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5184/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Feb 18, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5184/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95

aduh95 commented Feb 19, 2023

Copy link
Copy Markdown
Contributor

The commit message of a1a9d91 says "PR-URL: TODO", this would need to be amended I think.

MylesBorins reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request Feb 20, 2023
CI Reliability 2023-02-20 nodejs/reliability#501
Open
24 tasks
@MylesBorins
2023-02-21, Version 18.14.2 'Hydrogen' (LTS)
4df0001
Notable changes:

deps:
  * upgrade npm to 9.5.0 (npm team) #46673

PR-URL: #46724
@MylesBorins
MylesBorins force-pushed the v18.14.2-proposal branch from a1a9d91 to 4df0001 Compare February 20, 2023 02:43
@nodejs-github-bot

nodejs-github-bot commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49762/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos
targos approved these changes Feb 20, 2023
View reviewed changes
mcollina
mcollina approved these changes Feb 20, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
ruyadorno
ruyadorno approved these changes Feb 20, 2023
View reviewed changes
juanarbol
juanarbol approved these changes Feb 20, 2023
View reviewed changes

@juanarbol juanarbol left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@MylesBorins

MylesBorins commented Feb 20, 2023

Copy link
Copy Markdown
Contributor Author

rc.0: https://ci-release.nodejs.org/job/iojs+release/9164/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs
BethGriggs approved these changes Feb 20, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Feb 21, 2023
CI Reliability 2023-02-21 nodejs/reliability#502
Open
26 tasks
@MylesBorins

MylesBorins commented Feb 21, 2023

Copy link
Copy Markdown
Contributor Author

Tests are all green and nothing looks odd in CITGM. I'll do one last review of CITGM tomorrow before promoting the release.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@VoltrexKeyva VoltrexKeyva added release Issues and PRs related to Node.js releases. and removed meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry. labels Feb 21, 2023
@MylesBorins

MylesBorins commented Feb 21, 2023

Copy link
Copy Markdown
Contributor Author

There is a newish failure with torrent-stream on certain *nix boxes but it is failing on 18.14.1 and on 18.4.0

I'm going to move forward with the release

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MylesBorins added a commit that referenced this pull request Feb 21, 2023
@MylesBorins
Working on v18.14.3
b266adb
PR-URL: #46724
@MylesBorins
MylesBorins merged commit 4df0001 into v18.x Feb 21, 2023
@MylesBorins
MylesBorins deleted the v18.14.2-proposal branch February 21, 2023 18:10
MylesBorins added a commit that referenced this pull request Feb 21, 2023
@MylesBorins
2023-02-21, Version 18.14.2 'Hydrogen' (LTS)
6a80a2b
Notable changes:

deps:
  * upgrade npm to 9.5.0 (npm team) #46673

PR-URL: #46724
MylesBorins added a commit to nodejs/nodejs.org that referenced this pull request Feb 21, 2023
@MylesBorins
blog: release notes for v19.7.0 and v18.14.2
f1cf24c
Refs:nodejs/node#46725
Refs: nodejs/node#46724
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2023
blog: release notes for v19.7.0 and v18.14.2 nodejs/nodejs.org#5064
Merged
Trott pushed a commit to nodejs/nodejs.org that referenced this pull request Feb 21, 2023
@MylesBorins
blog: release notes for v19.7.0 and v18.14.2 (#5064)
96525c8
Refs:nodejs/node#46725
Refs: nodejs/node#46724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@ruyadorno ruyadorno ruyadorno approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
@juanarbol juanarbol juanarbol approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. release Issues and PRs related to Node.js releases.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@MylesBorins @nodejs-github-bot @aduh95 @mcollina @ruyadorno @targos @BethGriggs @juanarbol @VoltrexKeyva @npm-cli-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.