GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v18.x backport] test: add WPTRunner support for variants and generating WPT reports by panva · Pull Request #46767 · nodejs/node

Conversation

@panva

@panva panva commented Feb 22, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Backports #46498, #46778, and #46804 to v18.x.

Enables WPT Report for future v18.x LTS releases.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@panva
test: add WPTRunner support for variants and generating WPT reports
8812c56 
PR-URL: nodejs#46498
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Backport-PR-URL: nodejs#46767
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v18.x labels Feb 22, 2023
@panva
panva force-pushed the backport-46498-to-v18.x branch from e55d6bd to 8812c56 Compare February 22, 2023 10:26
@panva
panva marked this pull request as ready for review February 22, 2023 10:27
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 22, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 22, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Feb 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49877/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Feb 22, 2023
View reviewed changes

@anonrig anonrig left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. wip Issues and PRs that are still a work in progress. and removed author ready PRs with CI started, the required approvals, and no outstanding review comments. wip Issues and PRs that are still a work in progress. labels Feb 22, 2023
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed wip Issues and PRs that are still a work in progress. labels Feb 22, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 22, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva
test: fix default WPT titles
5d45158 
PR-URL: nodejs#46778
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Backport-PR-URL: nodejs#46767
@panva
panva force-pushed the backport-46498-to-v18.x branch from f88b581 to 5d45158 Compare February 22, 2023 21:52
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 22, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 22, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions Bot mentioned this pull request Feb 23, 2023
CI Reliability 2023-02-23 nodejs/reliability#504
Open
31 tasks
@panva
panva marked this pull request as ready for review February 25, 2023 19:35
@panva panva added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Feb 25, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50002/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Feb 26, 2023
CI Reliability 2023-02-26 nodejs/reliability#507
Open
15 tasks
@nodejs-github-bot

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50012/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50022/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50025/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50026/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50034/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva

panva commented Feb 26, 2023

Copy link
Copy Markdown
Member Author

cc @nodejs/backporters if possible, please land 🙏 so that the next v18.x tagged release starts submitting runs to wpt.fyi like nightly and 19.x already do.

This does not affect the build, it merely enables the daily wpt workflow to create the report for future v18.x releases.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50038/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50040/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Feb 27, 2023
CI Reliability 2023-02-27 nodejs/reliability#508
Open
13 tasks
@nodejs-github-bot

nodejs-github-bot commented Feb 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50043/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Feb 27, 2023
View reviewed changes
@panva panva mentioned this pull request Feb 27, 2023
Submitting WPT results to wpt.fyi for comparison #46443
Closed
This was referenced Feb 28, 2023
CI Reliability 2023-02-28 nodejs/reliability#509
Open
CI Reliability 2023-03-01 nodejs/reliability#510
Open
richardlau
richardlau approved these changes Mar 1, 2023
View reviewed changes
@panva panva mentioned this pull request Mar 3, 2023
V18.15.0 proposal #46920
Merged
@juanarbol juanarbol removed the needs-ci PRs that need a full CI run. label Mar 5, 2023
@juanarbol
juanarbol force-pushed the v18.x-staging branch from e17d857 to de64315 Compare March 5, 2023 04:04
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@panva @juanarbol
test: add WPTRunner support for variants and generating WPT reports
5f422c4 
PR-URL: #46498
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Backport-PR-URL: #46767
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@panva @juanarbol
test: fix default WPT titles
162e340 
PR-URL: #46778
Backport-PR-URL: #46767
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@panva @juanarbol
test: fix WPT title when no META title is present
de64315 
PR-URL: #46804
Backport-PR-URL: #46767
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@juanarbol

juanarbol commented Mar 5, 2023

Copy link
Copy Markdown
Member

Landed in 492fc95...de64315
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol juanarbol closed this Mar 5, 2023
@panva
panva deleted the backport-46498-to-v18.x branch March 5, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@panva @nodejs-github-bot @juanarbol @anonrig @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.