GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: reduce flakiness of parallel/test-http-remove-header-stays-removed.js by debadree25 · Pull Request #46855 · nodejs/node

Conversation

@debadree25

@debadree25 debadree25 commented Feb 27, 2023

Copy link
Copy Markdown
Contributor

The test test-http-remove-header-stays-removed.js seems to be slightly flaky as seen in nodejs/reliability#508 and also reproducible locally by running python3 tools/test.py test/parallel/test-http-remove-header-stays-removed.js --repeat 1000

Since the test checks that the socket is closed right after receiving the last chunk of data hence moved the checking for the same after the data has been received and slightly increased the timeout, the flakiness no longer reproduces

Refs: nodejs/reliability#508
Refs: #46333

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Feb 27, 2023
@debadree25
debadree25 force-pushed the ft/improve-test-http-remove-header branch from 37b2da5 to 2c2b37c Compare February 27, 2023 07:34
@debadree25 debadree25 changed the title test: reduce flakiness of test/parallel/test-http-remove-header-stays-removed.js test: reduce flakiness of parallel/test-http-remove-header-stays-removed.js Feb 27, 2023
@debadree25 debadree25 added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label Feb 27, 2023
@debadree25
test: reduce flakiness of test-http-remove-header-stays-removed.js
e0e39c6 
Refs: nodejs/reliability#508
Refs: nodejs#46333
@debadree25
debadree25 force-pushed the ft/improve-test-http-remove-header branch from 2c2b37c to e0e39c6 Compare February 27, 2023 07:36
@debadree25
debadree25 requested review from mcollina and ronag February 27, 2023 07:36
@ronag

ronag commented Feb 27, 2023

Copy link
Copy Markdown
Member

Does this allow a bug during flakiness?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@debadree25

debadree25 commented Feb 27, 2023

Copy link
Copy Markdown
Contributor Author

Does this allow a bug during flakiness?

Didn't get you? 😅😅
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@debadree25 debadree25 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 28, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 28, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
This was referenced Mar 1, 2023
CI Reliability 2023-03-01 nodejs/reliability#510
Open
CI Reliability 2023-03-02 nodejs/reliability#511
Open
@nodejs-github-bot

nodejs-github-bot commented Mar 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50144/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Mar 3, 2023
CI Reliability 2023-03-03 nodejs/reliability#512
Open
18 tasks
@debadree25

debadree25 commented Mar 11, 2023

Copy link
Copy Markdown
Contributor Author

ping @ronag
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina reviewed Mar 13, 2023
View reviewed changes
Comment thread test/parallel/test-http-remove-header-stays-removed.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@debadree25 @mcollina
Update test/parallel/test-http-remove-header-stays-removed.js
8a34390 
Co-authored-by: Matteo Collina <[email protected]>
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 13, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50352/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@debadree25
debadree25 requested a review from mcollina March 16, 2023 10:30
mcollina
mcollina approved these changes Mar 16, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@debadree25 debadree25 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Mar 16, 2023
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 18, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 18, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 9ce2f4f into nodejs:main Mar 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 18, 2023

Copy link
Copy Markdown
Collaborator

Landed in 9ce2f4f
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@debadree25 @RafaelGSS
test: reduce flakiness of test-http-remove-header-stays-removed.js
0bea595 
Refs: nodejs/reliability#508
Refs: #46333
PR-URL: #46855
Reviewed-By: Matteo Collina <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
v19.9.0 proposal #47441
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@debadree25 @RafaelGSS
test: reduce flakiness of test-http-remove-header-stays-removed.js
49981b9 
Refs: nodejs/reliability#508
Refs: #46333
PR-URL: #46855
Reviewed-By: Matteo Collina <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@debadree25 @danielleadams
test: reduce flakiness of test-http-remove-header-stays-removed.js
732a98e 
Refs: nodejs/reliability#508
Refs: #46333
PR-URL: #46855
Reviewed-By: Matteo Collina <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@ronag ronag Awaiting requested review from ronag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@debadree25 @ronag @nodejs-github-bot @mcollina @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.