GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — repl: preserve preview on ESCAPE key press by meixg · Pull Request #46878 · nodejs/node

Conversation

@meixg

@meixg meixg commented Feb 28, 2023 •
edited by aduh95
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes: #46876

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Feb 28, 2023
@meixg
meixg force-pushed the repl-escape-preview branch from 21dc2b9 to 61416f4 Compare February 28, 2023 10:08
@meixg meixg added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 28, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 28, 2023
@meixg
meixg force-pushed the repl-escape-preview branch from 61416f4 to d636ce8 Compare February 28, 2023 10:16
@nodejs-github-bot

nodejs-github-bot commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50092/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BridgeAR
BridgeAR reviewed Feb 28, 2023
View reviewed changes

@BridgeAR BridgeAR left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a nice improvement!
I would just not negate the argument and use an if statement.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread lib/internal/repl/utils.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/repl/utils.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/repl.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
BridgeAR
BridgeAR approved these changes Feb 28, 2023
View reviewed changes
Comment thread lib/internal/repl/utils.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR BridgeAR added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 28, 2023
BridgeAR
BridgeAR reviewed Feb 28, 2023
View reviewed changes

@BridgeAR BridgeAR left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that this might require a bit more work: in case the line completion and the preview is active, it should remove both.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50094/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@meixg

meixg commented Feb 28, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I just noticed that this might require a bit more work: in case the line completion and the preview is active, it should remove both.

Do you mean:

> let someStr = '123'
undefined
> '0' + someStr // <- '0' + som
'0123'

then press escape ? I tried and it will remove both.

> let someStr = '123'
undefined
> '0' + som
BridgeAR reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR

BridgeAR commented Feb 28, 2023

Copy link
Copy Markdown
Member

@meixg yes, that's what I meant. I just saw that it will work as expected due to resetting the preview suffix to null and therefore not having a match anymore. Good work!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Mar 1, 2023
CI Reliability 2023-03-01 nodejs/reliability#510
Open
15 tasks
@nodejs-github-bot

nodejs-github-bot commented Mar 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50116/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Mar 2, 2023
CI Reliability 2023-03-02 nodejs/reliability#511
Open
CI Reliability 2023-03-03 nodejs/reliability#512
Open
@nodejs-github-bot

nodejs-github-bot commented Mar 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50177/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
meixg and others added 2 commits March 3, 2023 11:25
@meixg
repl: preserve preview on ESCAPE key press
90c08fe 
Fix: nodejs#46876
@meixg @BridgeAR
Change noCompletion to showCompletion
3ede267 
Co-authored-by: Ruben Bridgewater <[email protected]>
@meixg
meixg force-pushed the repl-escape-preview branch from 7eef4d7 to 24cec13 Compare March 3, 2023 03:26
@meixg meixg added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 3, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50178/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50209/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50218/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@meixg
repl: preserve preview on ESCAPE key press
3e54f3a 
change according to cr
@meixg
meixg force-pushed the repl-escape-preview branch from 24cec13 to 3e54f3a Compare March 10, 2023 11:36
@meixg meixg added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 10, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 10, 2023
@meixg meixg added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 11, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 11, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50317/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50321/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Mar 12, 2023
CI Reliability 2023-03-12 nodejs/reliability#521
Open
CI Reliability 2023-03-13 nodejs/reliability#522
Open
@nodejs-github-bot

nodejs-github-bot commented Mar 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50351/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Mar 14, 2023
CI Reliability 2023-03-14 nodejs/reliability#523
Open
24 tasks
@nodejs-github-bot

nodejs-github-bot commented Mar 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50374/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50378/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BridgeAR
BridgeAR approved these changes Mar 14, 2023
View reviewed changes

@BridgeAR BridgeAR left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
This was referenced Mar 15, 2023
CI Reliability 2023-03-15 nodejs/reliability#524
Open
CI Reliability 2023-03-16 nodejs/reliability#525
Open
@meixg meixg added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Mar 16, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 16, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 2566400 into nodejs:main Mar 16, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 16, 2023

Copy link
Copy Markdown
Collaborator

Landed in 2566400
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Mar 17, 2023
CI Reliability 2023-03-17 nodejs/reliability#526
Open
CI Reliability 2023-03-18 nodejs/reliability#527
Open
targos pushed a commit that referenced this pull request Mar 18, 2023
@meixg @targos
repl: preserve preview on ESCAPE key press
d6a1232 
Fix: #46876
PR-URL: #46878
Fixes: #46876
Reviewed-By: Ruben Bridgewater <[email protected]>
This was referenced Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
v19.9.0 proposal #47441
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@meixg @danielleadams
repl: preserve preview on ESCAPE key press
e668efa 
Fix: #46876
PR-URL: #46878
Fixes: #46876
Reviewed-By: Ruben Bridgewater <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
@meixg
meixg deleted the repl-escape-preview branch April 21, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

repl: preview removed when press ESC key

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@meixg @nodejs-github-bot @BridgeAR
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.