GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — url: allow extension of user provided URL objects by aduh95 · Pull Request #46989 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

Fixes: #46981

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@aduh95
url: allow extension of user provided URL objects
da226b5
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Mar 7, 2023
@aduh95 aduh95 mentioned this pull request Mar 7, 2023
new internal isURL check can result in http.request() option fields being ignored #46981
Closed
anonrig
anonrig reviewed Mar 7, 2023
View reviewed changes
Comment thread lib/internal/url.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/url.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig reviewed Mar 7, 2023
View reviewed changes
Comment thread lib/internal/url.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
fixup! url: allow extension of user provided URL objects
fa31017
@anonrig anonrig mentioned this pull request Mar 7, 2023
test: remove unnecessary urlToHttpOptions test #47002
Closed
trentm
trentm reviewed Mar 9, 2023
View reviewed changes

@trentm trentm left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (caveat: I'm not a nodejs reviewer)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95
aduh95 requested a review from anonrig March 18, 2023 11:19
anonrig
anonrig approved these changes Mar 18, 2023
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Mar 18, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50443/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50452/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Mar 19, 2023
CI Reliability 2023-03-19 nodejs/reliability#528
Open
19 tasks
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 19, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 19, 2023
@nodejs-github-bot
nodejs-github-bot merged commit ad2c3c0 into nodejs:main Mar 19, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 19, 2023

Copy link
Copy Markdown
Collaborator

Landed in ad2c3c0
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Mar 20, 2023
CI Reliability 2023-03-20 nodejs/reliability#530
Open
CI Reliability 2023-03-21 nodejs/reliability#531
Open
CI Reliability 2023-03-22 nodejs/reliability#532
Open
@trentm trentm mentioned this pull request Mar 30, 2023
HttpConnection.buildRequestObject includes non-http.request fields, which breaks in recent node v20 nightly elastic/elastic-transport-js#59
Closed
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@aduh95 @RafaelGSS
url: allow extension of user provided URL objects
306d230 
PR-URL: #46989
Fixes: #46981
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
v19.9.0 proposal #47441
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@aduh95 @RafaelGSS
url: allow extension of user provided URL objects
0b565e8 
PR-URL: #46989
Fixes: #46981
Reviewed-By: Yagiz Nizipli <[email protected]>
@anonrig anonrig mentioned this pull request Jun 24, 2023
[v18.x] backport Ada v2.x to Node.js v18 #48345
Closed
19 tasks done
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@aduh95 @danielleadams
url: allow extension of user provided URL objects
b04ea5a 
PR-URL: #46989
Fixes: #46981
Reviewed-By: Yagiz Nizipli <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 9, 2023
@aduh95 @anonrig
url: allow extension of user provided URL objects
353bab0 
PR-URL: nodejs#46989
Fixes: nodejs#46981
Reviewed-By: Yagiz Nizipli <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@aduh95 @danielleadams
url: allow extension of user provided URL objects
4784e64 
PR-URL: #46989
Backport-PR-URL: #48345
Fixes: #46981
Reviewed-By: Yagiz Nizipli <[email protected]>
@danielleadams danielleadams added the backported-to-v18.x label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
+2 more reviewers
@trentm trentm trentm left review comments
@TimothyGu TimothyGu TimothyGu left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

new internal isURL check can result in http.request() option fields being ignored

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@aduh95 @nodejs-github-bot @trentm @TimothyGu @anonrig @danielleadams
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.