GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test,crypto: update WebCryptoAPI WPT by panva · Pull Request #47010 · nodejs/node

Conversation

@panva

@panva panva commented Mar 8, 2023

Copy link
Copy Markdown
Member

Just git node wpt WebCryptoAPI.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@panva
test,crypto: update WebCryptoAPI WPT
b2a1015
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Mar 8, 2023
@panva panva added crypto Issues and PRs related to the crypto subsystem. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. webcrypto Issues and PRs related to the Web Crypto API. labels Mar 8, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 8, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50276/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Mar 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50277/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95
aduh95 approved these changes Mar 8, 2023
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 8, 2023
anonrig
anonrig approved these changes Mar 8, 2023
View reviewed changes
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 8, 2023
This was referenced Mar 9, 2023
CI Reliability 2023-03-09 nodejs/reliability#518
Open
CI Reliability 2023-03-10 nodejs/reliability#519
Open
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 10, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 57c4070 into nodejs:main Mar 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in 57c4070

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@panva
panva deleted the wpt-update-crypto branch March 10, 2023 10:53
This was referenced Mar 11, 2023
CI Reliability 2023-03-11 nodejs/reliability#520
Open
CI Reliability 2023-03-12 nodejs/reliability#521
Open
CI Reliability 2023-03-13 nodejs/reliability#522
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
@panva @targos
test,crypto: update WebCryptoAPI WPT
8886840
PR-URL: #47010
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@github-actions github-actions Bot mentioned this pull request Mar 14, 2023
CI Reliability 2023-03-14 nodejs/reliability#523
Open
24 tasks
targos pushed a commit that referenced this pull request Mar 14, 2023
@panva @targos
test,crypto: update WebCryptoAPI WPT
13f14a5
PR-URL: #47010
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
v19.8.0 release proposal #47087
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@panva @danielleadams
test,crypto: update WebCryptoAPI WPT
5e008e7
PR-URL: #47010
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
v18.16.0 release proposal #47502
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. webcrypto Issues and PRs related to the Web Crypto API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@panva @nodejs-github-bot @anonrig @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.