GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Skip broken tests on Windows ARM64 by StefanStojanovic · Pull Request #47020 · nodejs/node

Conversation

@StefanStojanovic

@StefanStojanovic StefanStojanovic commented Mar 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR marks 2 tests for skipping on Windows on ARM. The changes introduced here aim to enable passing JS test suites in the CI. There is another PR that focuses on native test suites. Together their goal is to enable Windows ARM64 tests in CI

cc @nodejs/platform-windows-arm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
p-b-o reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Mar 8, 2023
@niyas-sait

niyas-sait commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

Thanks, @StefanStojanovic. Looks good to me.
StefanStojanovic reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StefanStojanovic StefanStojanovic changed the title Test: mark win arm64 flaky tests Marking broken tests on Windows ARM64 Mar 13, 2023
@StefanStojanovic StefanStojanovic changed the title Marking broken tests on Windows ARM64 Skip broken tests on Windows ARM64 Mar 13, 2023
@StefanStojanovic
StefanStojanovic force-pushed the mefi-arm64-flaky-tests branch from a12ebf7 to 1da7569 Compare March 13, 2023 14:06
@StefanStojanovic

StefanStojanovic commented Mar 13, 2023

Copy link
Copy Markdown
Contributor Author

@sxa @richardlau hey, I'm not sure who to ping for this. I saw you were active on ARM64 and some test PRs in the past so I picked you. Anyway, I wanted to see if there is something I can do to help move this forward.

I apologize for pinging you and if there is someone else who I should ping for this please let me know. Thanks in advance.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau reviewed Mar 14, 2023
View reviewed changes
Comment thread test/parallel/parallel.status Resolved

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau mentioned this pull request Mar 14, 2023
test: fix test-permission-deny-fs-wildcard (win32) #47095
Merged
@StefanStojanovic
test: skip broken tests win arm64
5e8dfbc
@StefanStojanovic
StefanStojanovic force-pushed the mefi-arm64-flaky-tests branch from 1da7569 to 5e8dfbc Compare March 15, 2023 13:09
richardlau
richardlau approved these changes Mar 20, 2023
View reviewed changes
targos
targos approved these changes Mar 20, 2023
View reviewed changes
@StefanStojanovic

StefanStojanovic commented Mar 21, 2023

Copy link
Copy Markdown
Contributor Author

@richardlau @targos can one of you trigger CI and/or merge this, please?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 21, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50519/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Mar 22, 2023
CI Reliability 2023-03-22 nodejs/reliability#532
Open
19 tasks
@joaocgreis joaocgreis mentioned this pull request Mar 22, 2023
Enable Windows Arm64 tests in CI nodejs/build#3046
Closed
@nodejs-github-bot

nodejs-github-bot commented Mar 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50536/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added commit-queue PRs queued for automated landing through the Commit Queue. windows Issues and PRs related to the Windows platform. arm Issues and PRs related to the ARM architecture. labels Mar 22, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 22, 2023
@nodejs-github-bot
nodejs-github-bot merged commit f086555 into nodejs:main Mar 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 22, 2023

Copy link
Copy Markdown
Collaborator

Landed in f086555
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Mar 23, 2023
CI Reliability 2023-03-23 nodejs/reliability#533
Open
33 tasks
StefanStojanovic added a commit to JaneaSystems/node that referenced this pull request Mar 23, 2023
@StefanStojanovic
test: fix test-child-process-exec-cwd
5cc22ee 
Refs: nodejs#47020
Refs: nodejs/build#3046
@StefanStojanovic StefanStojanovic mentioned this pull request Mar 23, 2023
Fix test-child-process-exec-cwd for Windows on ARM64 #47235
Merged
nodejs-github-bot pushed a commit that referenced this pull request Mar 27, 2023
@StefanStojanovic
test: fix test-child-process-exec-cwd
13767a4 
Refs: #47020
Refs: nodejs/build#3046
PR-URL: #47235
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 28, 2023
@StefanStojanovic @richardlau
test: skip broken tests win arm64
4fdaab8 
PR-URL: #47020
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 28, 2023
@StefanStojanovic @richardlau
test: fix test-child-process-exec-cwd
a84c2c5 
Refs: #47020
Refs: nodejs/build#3046
PR-URL: #47235
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
This was referenced Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
v19.9.0 proposal #47441
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@StefanStojanovic @RafaelGSS
test: skip broken tests win arm64
41a69e7 
PR-URL: #47020
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@StefanStojanovic @RafaelGSS
test: fix test-child-process-exec-cwd
6772aa6 
Refs: #47020
Refs: nodejs/build#3046
PR-URL: #47235
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@StefanStojanovic @danielleadams
test: skip broken tests win arm64
0dc4971 
PR-URL: #47020
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@StefanStojanovic @danielleadams
test: fix test-child-process-exec-cwd
1e6fe56 
Refs: #47020
Refs: nodejs/build#3046
PR-URL: #47235
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

arm Issues and PRs related to the ARM architecture. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@StefanStojanovic @niyas-sait @nodejs-github-bot @targos @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.