GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc,test: extend the list of platforms supported by single-executables by RaisinTen · Pull Request #47026 · nodejs/node

Conversation

@RaisinTen

@RaisinTen RaisinTen commented Mar 9, 2023

Copy link
Copy Markdown
Member

Now that #46934 has landed, we can extend the list of platforms and architectures where we can run the single-executable test.

(Initially tested this in #46868)

cc @nodejs/single-executable

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RaisinTen
doc,test: extend the list of platforms supported by single-executables
f37132b 
Now that nodejs#46934 has landed, we can
extend the list of platforms and architectures where we can run the
single-executable test.

Signed-off-by: Darshan Sen <[email protected]>
@RaisinTen RaisinTen added the single-executable Issues and PRs related to single-executable applications. label Mar 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 9, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 9, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
targos
targos reviewed Mar 9, 2023
View reviewed changes
Comment thread doc/api/single-executable-applications.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen
doc: be more specific about supported platforms
39eeeea 
Refs: nodejs#47026 (comment)
Signed-off-by: Darshan Sen <[email protected]>
tony-go
tony-go approved these changes Mar 9, 2023
View reviewed changes

@tony-go tony-go left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm & my comment

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test/parallel/test-single-executable-application.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen @tony-go
test: improve readability
a2e0758 
Refs: nodejs#47026 (comment)

Co-authored-by: Tony Gorez <[email protected]>
debadree25
debadree25 approved these changes Mar 9, 2023
View reviewed changes
@debadree25

debadree25 commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

(unrelated) Are there any tracking issues for the failures in these different platforms? would love to try my hand 😅
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Mar 9, 2023
View reviewed changes
@RaisinTen

RaisinTen commented Mar 10, 2023

Copy link
Copy Markdown
Member Author

(unrelated) Are there any tracking issues for the failures in these different platforms? would love to try my hand 😅

I haven't spent time investigating the remaining failures to come up with issues that are descriptive enough yet, maybe you could help out with that?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 10, 2023
@RaisinTen

This comment was marked as outdated.

Sign in to view
@debadree25

debadree25 commented Mar 10, 2023

Copy link
Copy Markdown
Contributor

I haven't spent time investigating the remaining failures to come up with issues that are descriptive enough yet, maybe you could help out with that?

Best way to reproduce these locally? using a vm? if yes any recommendations on that?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen

RaisinTen commented Mar 10, 2023

Copy link
Copy Markdown
Member Author

I normally use Parallels if I have to use a VM. If an issue still doesn't repro there, we can request access to a system in the build repo like I did in nodejs/build#3207.
debadree25 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aymen94
aymen94 approved these changes Mar 10, 2023
View reviewed changes
mcollina
mcollina approved these changes Mar 10, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RaisinTen RaisinTen added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Mar 11, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 11, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50315/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen RaisinTen added the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 11, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 11, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 86c831f into nodejs:main Mar 11, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 11, 2023

Copy link
Copy Markdown
Collaborator

Landed in 86c831f
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen
RaisinTen deleted the doc,test/extend-supported-platforms branch March 11, 2023 08:59
targos pushed a commit that referenced this pull request Mar 13, 2023
@RaisinTen @targos
doc,test: extend the list of platforms supported by single-executables
f4b3ce8 
Now that #46934 has landed, we can
extend the list of platforms and architectures where we can run the
single-executable test.

Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #47026
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
@RaisinTen @targos
doc,test: extend the list of platforms supported by single-executables
458671d 
Now that #46934 has landed, we can
extend the list of platforms and architectures where we can run the
single-executable test.

Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #47026
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
v19.8.0 release proposal #47087
Merged
@danielleadams

danielleadams commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

This is blocked by #45038
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danielleadams danielleadams added the backport-blocked-v18.x label Apr 4, 2023
targos pushed a commit that referenced this pull request Nov 10, 2023
@RaisinTen @targos
doc,test: extend the list of platforms supported by single-executables
8a57182 
Now that #46934 has landed, we can
extend the list of platforms and architectures where we can run the
single-executable test.

Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #47026
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc,test: extend the list of platforms supported by
0bc4b6a 
Now that nodejs/node#46934 has landed, we can
extend the list of platforms and architectures where we can run the
single-executable test.

Signed-off-by: Darshan Sen <[email protected]>
PR-URL: nodejs/node#47026
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc,test: extend the list of platforms supported by
7872557 
Now that nodejs/node#46934 has landed, we can
extend the list of platforms and architectures where we can run the
single-executable test.

Signed-off-by: Darshan Sen <[email protected]>
PR-URL: nodejs/node#47026
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@cjihrig cjihrig cjihrig approved these changes
+4 more reviewers
@targos targos targos left review comments
@aymen94 aymen94 aymen94 approved these changes
@debadree25 debadree25 debadree25 approved these changes
@tony-go tony-go tony-go approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@RaisinTen @nodejs-github-bot @debadree25 @danielleadams @mcollina @targos @cjihrig @aymen94 @tony-go
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.