GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — meta: ask expected behavior reason in bug template by bnoordhuis · Pull Request #47049 · nodejs/node

Conversation

@bnoordhuis

@bnoordhuis bnoordhuis commented Mar 12, 2023

Copy link
Copy Markdown
Member

It happens too often that bug reporters only report what they expect to see without motivating why. Having to repeatedly ask for that info gets old.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bnoordhuis
meta: ask expected behavior reason in bug template
d77b60e
It happens too often that bug reporters only report _what_ they expect
to see without motivating _why_. Having to repeatedly ask for that info
gets old.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 12, 2023
MoLow
MoLow approved these changes Mar 12, 2023
View reviewed changes

@MoLow MoLow left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
debadree25
debadree25 approved these changes Mar 12, 2023
View reviewed changes
VoltrexKeyva
VoltrexKeyva approved these changes Mar 12, 2023
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Mar 12, 2023
anonrig
anonrig approved these changes Mar 13, 2023
View reviewed changes
cjihrig
cjihrig approved these changes Mar 13, 2023
View reviewed changes
RaisinTen
RaisinTen approved these changes Mar 13, 2023
View reviewed changes
lpinca
lpinca approved these changes Mar 13, 2023
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 14, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 4ae7c7a into nodejs:main Mar 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 14, 2023

Copy link
Copy Markdown
Collaborator

Landed in 4ae7c7a

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos pushed a commit that referenced this pull request Mar 18, 2023
@bnoordhuis @targos
meta: ask expected behavior reason in bug template
b0aad34
It happens too often that bug reporters only report _what_ they expect
to see without motivating _why_. Having to repeatedly ask for that info
gets old.

PR-URL: #47049
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
v19.9.0 proposal #47441
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@bnoordhuis @danielleadams
meta: ask expected behavior reason in bug template
baada5d
It happens too often that bug reporters only report _what_ they expect
to see without motivating _why_. Having to repeatedly ask for that info
gets old.

PR-URL: #47049
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@cjihrig cjihrig cjihrig approved these changes
@MoLow MoLow MoLow approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+2 more reviewers
@debadree25 debadree25 debadree25 approved these changes
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@bnoordhuis @nodejs-github-bot @lpinca @anonrig @cjihrig @MoLow @debadree25 @RaisinTen @VoltrexKeyva @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.