GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — test_runner: accept \x1b as a escape symbol by debadree25 · Pull Request #47050 · nodejs/node

Conversation

debadree25 commented Mar 12, 2023

Copy link

Copy Markdown

Contributor

It seems that TAPLexer was throwing an error on the ANSI code \x1b hence added the same as a escape symbol

Fixes: #46959

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

tonivj5, bricss, and xuzaixian reacted with eyes emoji

All reactions

👍 1 reaction
👀 3 reactions

debadree25 added 2 commits

March 12, 2023 16:28


          test_runner: accept \x1b as a escape symbol

e6c262c

Fixes: nodejs#46959


          fixup! space

52c773d

nodejs-github-bot commented Mar 12, 2023

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/test_runner

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

debadree25 requested a review from MoLow

March 12, 2023 11:02

nodejs-github-bot added dont-land-on-v14.x needs-ci

PRs that need a full CI run.

test_runner Issues and PRs related to the test runner subsystem. labels

Mar 12, 2023

MoLow approved these changes

Mar 12, 2023

View reviewed changes

MoLow left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

debadree25 and bricss reacted with rocket emoji

All reactions

🚀 2 reactions

debadree25 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Mar 12, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Mar 12, 2023

This comment was marked as outdated.

nodejs-github-bot commented Mar 12, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50335/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

debadree25 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Mar 12, 2023

This was referenced Mar 13, 2023

CI Reliability 2023-03-13 nodejs/reliability#522

Open

CI Reliability 2023-03-14 nodejs/reliability#523

Open

CI Reliability 2023-03-15 nodejs/reliability#524

Open

MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label

Mar 15, 2023

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels

Mar 15, 2023

nodejs-github-bot commented Mar 15, 2023

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/47050
✔  Done loading data for nodejs/node/pull/47050
----------------------------------- PR info ------------------------------------
Title      test_runner: accept \x1b as a escape symbol (#47050)
Author     Debadree Chatterjee  (@debadree25)
Branch     debadree25:ft/tap-lexer-ansi-escape -> nodejs:main
Labels     author ready, needs-ci, dont-land-on-v14.x, test_runner
Commits    2
 - test_runner: accept \x1b as a escape symbol
 - fixup! space
Committers 1
 - Debadree Chatterjee 
PR-URL: https://github.com/nodejs/node/pull/47050
Fixes: https://github.com/nodejs/node/issues/46959
Reviewed-By: Moshe Atlow 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47050
Fixes: https://github.com/nodejs/node/issues/46959
Reviewed-By: Moshe Atlow 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 12 Mar 2023 11:01:47 GMT
   ✔  Approvals: 1
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/47050#pullrequestreview-1336012293
   ✘  This PR needs to wait 86 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-03-12T14:21:21Z: https://ci.nodejs.org/job/node-test-pull-request/50335/
- Querying data for job/node-test-pull-request/50335/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4430846114

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Mar 16, 2023

CI Reliability 2023-03-16 nodejs/reliability#525

Open

22 tasks

debadree25 commented Mar 16, 2023

Copy link

Copy Markdown

Contributor Author

would need another review to land

MoLow reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lpinca approved these changes

Mar 16, 2023

View reviewed changes

debadree25 added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels

Mar 16, 2023

nodejs-github-bot commented Mar 16, 2023

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/47050 ✔ Done loading data for nodejs/node/pull/47050 ----------------------------------- PR info ------------------------------------ Title test_runner: accept \x1b as a escape symbol (#47050) Author Debadree Chatterjee (@debadree25) Branch debadree25:ft/tap-lexer-ansi-escape -> nodejs:main Labels author ready, needs-ci, dont-land-on-v14.x, test_runner Commits 2 - test_runner: accept \x1b as a escape symbol - fixup! space Committers 1 - Debadree Chatterjee PR-URL: https://github.com/nodejs/node/pull/47050 Fixes: https://github.com/nodejs/node/issues/46959 Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47050 Fixes: https://github.com/nodejs/node/issues/46959 Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 12 Mar 2023 11:01:47 GMT ✔ Approvals: 2 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/47050#pullrequestreview-1336012293 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47050#pullrequestreview-1344628705 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-03-15T20:55:54Z: https://ci.nodejs.org/job/node-test-pull-request/50335/ - Querying data for job/node-test-pull-request/50335/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47050 From https://github.com/nodejs/node * branch refs/pull/47050/merge -> FETCH_HEAD ✔ Fetched commits as 8713c83462df..52c773d3e481 -------------------------------------------------------------------------------- [main 3955686063] test_runner: accept \x1b as a escape symbol Author: Debadree Chatterjee Date: Sun Mar 12 16:28:02 2023 +0530 2 files changed, 13 insertions(+), 1 deletion(-) [main 9b2bdf9330] fixup! space Author: Debadree Chatterjee Date: Sun Mar 12 16:28:34 2023 +0530 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)

Executing: git node land --amend --yes
⚠ Found Fixes: #46959, skipping..
--------------------------------- New Message ----------------------------------
test_runner: accept \x1b as a escape symbol

Fixes: #46959
PR-URL: #47050
Reviewed-By: Moshe Atlow [email protected]
Reviewed-By: Luigi Pinca [email protected]

[detached HEAD a3e046675b] test_runner: accept \x1b as a escape symbol
Author: Debadree Chatterjee [email protected]
Date: Sun Mar 12 16:28:02 2023 +0530
2 files changed, 13 insertions(+), 1 deletion(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup! space

PR-URL: #47050
Fixes: #46959
Reviewed-By: Moshe Atlow [email protected]
Reviewed-By: Luigi Pinca [email protected]

[detached HEAD 21df468a86] fixup! space
Author: Debadree Chatterjee [email protected]
Date: Sun Mar 12 16:28:34 2023 +0530
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/4441310390

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MoLow added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels

Mar 16, 2023

MoLow added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label

Mar 16, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Mar 16, 2023

nodejs-github-bot merged commit d51541b into nodejs:main

Mar 16, 2023

nodejs-github-bot commented Mar 16, 2023

Copy link

Copy Markdown

Collaborator

Landed in d51541b

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Mar 17, 2023

CI Reliability 2023-03-17 nodejs/reliability#526

Open

CI Reliability 2023-03-18 nodejs/reliability#527

Open

targos pushed a commit that referenced this pull request

Mar 18, 2023


          test_runner: accept \x1b as a escape symbol

5a43586

Fixes: #46959
PR-URL: #47050
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

This was referenced Apr 3, 2023

2023-04-18, Version 20.0.0 (Current) #47381

Merged

v19.9.0 proposal #47441

Merged

danielleadams pushed a commit that referenced this pull request

Jul 6, 2023


          test_runner: accept \x1b as a escape symbol

c62e6b2

Fixes: #46959
PR-URL: #47050
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

danielleadams mentioned this pull request

Jul 10, 2023

v18.17.0 release proposal #48694

Merged

Reviewers

lpinca

lpinca approved these changes

MoLow

MoLow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

needs-ci

PRs that need a full CI run.

test_runner

Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test runner breaks with ERR_TAP_LEXER_ERROR while trying a console.dir with colors flag set ( {colors: true} )

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

debadree25 commented Mar 12, 2023

Uh oh!

nodejs-github-bot commented Mar 12, 2023

Uh oh!

MoLow left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Mar 12, 2023

Uh oh!

nodejs-github-bot commented Mar 15, 2023

Uh oh!

debadree25 commented Mar 16, 2023

Uh oh!

nodejs-github-bot commented Mar 16, 2023

Fixes: #46959 PR-URL: #47050 Reviewed-By: Moshe Atlow [email protected] Reviewed-By: Luigi Pinca [email protected]

PR-URL: #47050 Fixes: #46959 Reviewed-By: Moshe Atlow [email protected] Reviewed-By: Luigi Pinca [email protected]

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented Mar 16, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fixes: #46959
PR-URL: #47050
Reviewed-By: Moshe Atlow [email protected]
Reviewed-By: Luigi Pinca [email protected]

PR-URL: #47050
Fixes: #46959
Reviewed-By: Moshe Atlow [email protected]
Reviewed-By: Luigi Pinca [email protected]