GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — meta: automate description requests when notable change label is added by danielleadams · Pull Request #47078 · nodejs/node

Conversation

@danielleadams

@danielleadams danielleadams commented Mar 14, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Adds a GH hook to leave a comment to ask for "Notable Change" descriptions.

Fixes: nodejs/Release#821

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Mar 14, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danielleadams danielleadams added the notable-change PRs with changes that should be highlighted in changelogs. label Mar 14, 2023
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 14, 2023
@danielleadams danielleadams removed the notable-change PRs with changes that should be highlighted in changelogs. label Mar 14, 2023
@danielleadams
danielleadams marked this pull request as ready for review March 14, 2023 02:24
@danielleadams danielleadams added the notable-change PRs with changes that should be highlighted in changelogs. label Mar 14, 2023
@danielleadams danielleadams closed this Mar 14, 2023
@danielleadams
danielleadams deleted the notable-change-bot branch March 15, 2023 11:42
@danielleadams
danielleadams restored the notable-change-bot branch March 15, 2023 17:44
@danielleadams danielleadams reopened this Mar 15, 2023
@danielleadams
danielleadams marked this pull request as draft March 15, 2023 17:45
@danielleadams
danielleadams marked this pull request as ready for review March 15, 2023 17:46
@danielleadams
danielleadams force-pushed the notable-change-bot branch from bc3692a to d2123c7 Compare March 15, 2023 17:53
@danielleadams danielleadams removed the notable-change PRs with changes that should be highlighted in changelogs. label Mar 15, 2023
BethGriggs
BethGriggs approved these changes Mar 15, 2023
View reviewed changes

@BethGriggs BethGriggs left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but unsure on how we can test it before landing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MoLow

MoLow commented Mar 15, 2023

Copy link
Copy Markdown
Member

LGTM, but unsure on how we can test it before landing.

that is what https://github.com/nodejs/node-auto-test is for
richardlau and danielleadams reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow approved these changes Mar 15, 2023
View reviewed changes
@danielleadams danielleadams changed the title chore: automate description requests when notable change label is added meta: automate description requests when notable change label is added Mar 15, 2023
@mhdawson

mhdawson commented Mar 15, 2023

Copy link
Copy Markdown
Member

I think new actions will not run on a PR as otherwise that would be an attack vector where anybody who submitted a PR could get us to run things. I think past best practice has been do do whatever testing you can in a personal repo and then land the PR and tweak through follow on PRs as necessary.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danielleadams

danielleadams commented Mar 16, 2023

Copy link
Copy Markdown
Contributor Author

I'm testing it on my fork and will report back
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danielleadams

danielleadams commented Mar 16, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Tested here: danielleadams#3 ✅
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danielleadams
danielleadams force-pushed the notable-change-bot branch from d2123c7 to 7723749 Compare March 16, 2023 13:05
bnb
bnb approved these changes Mar 16, 2023
View reviewed changes
@danielleadams
danielleadams force-pushed the notable-change-bot branch from 7723749 to 736c7fa Compare March 16, 2023 13:10
panva
panva reviewed Mar 16, 2023
View reviewed changes

@panva panva left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what the intended action item is based on the message. Is it to post a new comment or to edit the one made by the bot?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
bnb
bnb reviewed Mar 16, 2023
View reviewed changes
Comment thread .github/workflows/comment-labeled.yml Outdated

@bnb bnb Mar 16, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using gh pr comment like this is such a good idea. First time I've seen it, this is awesome.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
danielleadams reacted with laugh emoji
All reactions
  • 😄 1 reaction
@danielleadams

danielleadams commented Mar 16, 2023

Copy link
Copy Markdown
Contributor Author

I am not sure what the intended action item is based on the message. Is it to post a new comment or to edit the one made by the bot?

@panva you can do either. See nodejs/Release#821 - the change is to have better descriptions of notable changes so that the release notes are more consistent across release lines (and developers get better overall release notes), so how it's communicated is up to the PR author.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva

panva commented Mar 16, 2023

Copy link
Copy Markdown
Member

I am not sure what the intended action item is based on the message. Is it to post a new comment or to edit the one made by the bot?

@panva you can do either. See nodejs/Release#821 - the change is to have better descriptions of notable changes so that the release notes are more consistent across release lines (and developers get better overall release notes), so how it's communicated is up to the PR author.

Let's come up with a better copy then, one that works for both collaborators who can edit the bot's comment and contributors who don't. I'll try to jot something down later today.
danielleadams reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
panva
panva reviewed Mar 16, 2023
View reviewed changes
Comment thread .github/workflows/comment-labeled.yml Outdated
Comment on lines 14 to 18

@panva panva Mar 16, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The notable-changes label has been added by @${{ github.actor }}.
Please include your text below if you'd like to include a more detailed summary in the changelog.
```
[Insert here]
```
The ${{ github.event.label.url }} label has been added by @${{ github.actor }}.
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment.

Something along these lines. Feel free to play around with it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@panva panva Mar 16, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link will make the label appear like so notable-change PRs with changes that should be highlighted in changelogs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@danielleadams danielleadams Mar 19, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panva when I opened the PR, the event provided a different url (danielleadams#4 (comment)), so going to replace with the hard coded link.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@panva panva Mar 19, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@danielleadams
danielleadams force-pushed the notable-change-bot branch from 736c7fa to 01d6451 Compare March 19, 2023 00:27
@danielleadams
meta: automate description requests when notable change label is added
49f3a32
@danielleadams
danielleadams force-pushed the notable-change-bot branch from 01d6451 to 49f3a32 Compare March 19, 2023 00:42
targos
targos approved these changes Mar 22, 2023
View reviewed changes
Trott
Trott approved these changes Mar 24, 2023
View reviewed changes
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 24, 2023
@nodejs-github-bot
nodejs-github-bot merged commit d612613 into nodejs:main Mar 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 24, 2023

Copy link
Copy Markdown
Collaborator

Landed in d612613
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva

panva commented Mar 29, 2023

Copy link
Copy Markdown
Member

#47078 (comment)

I don't think this was reflected...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva added the notable-change PRs with changes that should be highlighted in changelogs. label Mar 29, 2023
@panva

panva commented Mar 29, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(testing, altho actions has degraded performance at this time so might take a while for the comment to appear, i'll keep tabs on this and follow up)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva added notable-change PRs with changes that should be highlighted in changelogs. and removed notable-change PRs with changes that should be highlighted in changelogs. labels Mar 29, 2023
@github-actions

github-actions Bot commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

The https://api.github.com/repos/nodejs/node/labels/notable-change label has been added by @panva.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva removed the notable-change PRs with changes that should be highlighted in changelogs. label Mar 29, 2023
@panva panva mentioned this pull request Mar 29, 2023
meta: fix notable-change comment label url #47300
Merged
@panva

panva commented Mar 29, 2023

Copy link
Copy Markdown
Member

#47300
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@danielleadams @RafaelGSS
meta: automate description requests when notable change label is added
fff36a1 
PR-URL: #47078
Fixes: nodejs/Release#821
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
v19.9.0 proposal #47441
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@danielleadams @RafaelGSS
meta: automate description requests when notable change label is added
dc024d9 
PR-URL: #47078
Fixes: nodejs/Release#821
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
danielleadams added a commit that referenced this pull request Jul 6, 2023
@danielleadams
meta: automate description requests when notable change label is added
3b524cb 
PR-URL: #47078
Fixes: nodejs/Release#821
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva left review comments
@bnb bnb bnb approved these changes
@Trott Trott Trott approved these changes
@MoLow MoLow MoLow approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Proposal: notable-changes bot comment for summaries

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@danielleadams @nodejs-github-bot @MoLow @mhdawson @panva @bnb @Trott @targos @BethGriggs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.