GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: fix duplication of externalized builtin code by kvakil · Pull Request #47079 · nodejs/node

Conversation

@kvakil

@kvakil kvakil commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

The else here was missing, causing us to append the file to its existing source already in the map.

Refs: #45942

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kvakil
src: fix duplication of externalized builtin code
fd3252e 
The `else` here was missing, causing us to append the file to its
existing `source` already in the map.

Refs: nodejs#45942
@nodejs-github-bot

nodejs-github-bot commented Mar 14, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 14, 2023
@kvakil kvakil added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 14, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50368/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Mar 14, 2023
View reviewed changes
@addaleax addaleax added fast-track PRs proposed for a shorter-than-standard waiting period before landing. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Mar 14, 2023
@github-actions

github-actions Bot commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @addaleax. Please 👍 to approve.
cjihrig, lpinca, debadree25, and anonrig reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 14, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
cjihrig
cjihrig approved these changes Mar 14, 2023
View reviewed changes
@kvakil kvakil added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 15, 2023
lpinca
lpinca approved these changes Mar 15, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50397/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50399/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kvakil

kvakil commented Mar 16, 2023

Copy link
Copy Markdown
Contributor Author

Can somebody retry the failed CI build for me because I cannot? It looks like the build timed out after 60 minutes on node-test-linux-linked-openssl111fips, which seems obviously unrelated: https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubi81_sharedlibs_openssl111fips_x64/36558/

Thanks :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50405/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kvakil kvakil added the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 17, 2023
@github-actions github-actions Bot mentioned this pull request Mar 17, 2023
CI Reliability 2023-03-17 nodejs/reliability#526
Open
19 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 17, 2023
@nodejs-github-bot
nodejs-github-bot merged commit c3537ae into nodejs:main Mar 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 17, 2023

Copy link
Copy Markdown
Collaborator

Landed in c3537ae
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Mar 18, 2023
CI Reliability 2023-03-18 nodejs/reliability#527
Open
23 tasks
targos pushed a commit that referenced this pull request Mar 18, 2023
@kvakil @targos
src: fix duplication of externalized builtin code
2fd0f79 
The `else` here was missing, causing us to append the file to its
existing `source` already in the map.

Refs: #45942
PR-URL: #47079
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Mar 19, 2023
CI Reliability 2023-03-19 nodejs/reliability#528
Open
CI Reliability 2023-03-20 nodejs/reliability#530
Open
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
v19.9.0 proposal #47441
Merged
@danielleadams danielleadams added the backport-blocked-v18.x label Jun 12, 2023
targos pushed a commit that referenced this pull request Nov 10, 2023
@kvakil @targos
src: fix duplication of externalized builtin code
3552afb 
The `else` here was missing, causing us to append the file to its
existing `source` already in the map.

Refs: #45942
PR-URL: #47079
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
src: fix duplication of externalized builtin code
56fe11b 
The `else` here was missing, causing us to append the file to its
existing `source` already in the map.

Refs: nodejs/node#45942
PR-URL: nodejs/node#47079
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
src: fix duplication of externalized builtin code
591699b 
The `else` here was missing, causing us to append the file to its
existing `source` already in the map.

Refs: nodejs/node#45942
PR-URL: nodejs/node#47079
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@kvakil @nodejs-github-bot @addaleax @lpinca @cjihrig @danielleadams
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.