GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: indicate that `name` is no longer an optional argument by danielroe · Pull Request #47102 · nodejs/node

Conversation

@danielroe

@danielroe danielroe commented Mar 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

resolves #47097

This updates the documentation around performance.mark() to indicate that the name argument is not optional, and that this change was made in Node 19.0.0.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
dargmuesli, bricss, and ijkml reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. perf_hooks Issues and PRs related to the perf_hooks module and performance measurement APIs. labels Mar 15, 2023
@danielroe
doc: indicate that name is no longer an optional argument
33f310e
@danielroe
danielroe force-pushed the patch-1 branch from c663e2d to 33f310e Compare March 15, 2023 12:35
@danielroe danielroe changed the title docs: indicate that name is no longer an optional argument doc: indicate that name is no longer an optional argument Mar 15, 2023
debadree25
debadree25 approved these changes Mar 15, 2023
View reviewed changes
@targos targos added dont-land-on-v14.x labels Mar 15, 2023
legendecas
legendecas approved these changes Mar 15, 2023
View reviewed changes
@debadree25 debadree25 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 15, 2023
anonrig
anonrig approved these changes Mar 15, 2023
View reviewed changes
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 15, 2023
cjihrig
cjihrig approved these changes Mar 15, 2023
View reviewed changes
lpinca
lpinca approved these changes Mar 15, 2023
View reviewed changes
HarshithaKP
HarshithaKP approved these changes Mar 16, 2023
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 17, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 7deb09c into nodejs:main Mar 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 17, 2023

Copy link
Copy Markdown
Collaborator

Landed in 7deb09c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danielroe
danielroe deleted the patch-1 branch March 17, 2023 13:04
targos pushed a commit that referenced this pull request Mar 18, 2023
@danielroe @targos
doc: indicate that name is no longer an optional argument
c08995e 
PR-URL: #47102
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
This was referenced Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
v19.9.0 proposal #47441
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@cjihrig cjihrig cjihrig approved these changes
@legendecas legendecas legendecas approved these changes
@HarshithaKP HarshithaKP HarshithaKP approved these changes
+1 more reviewer
@debadree25 debadree25 debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. perf_hooks Issues and PRs related to the perf_hooks module and performance measurement APIs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

performance.mark() throws error 'The "name" argument must be specified'

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@danielroe @nodejs-github-bot @lpinca @anonrig @cjihrig @legendecas @debadree25 @HarshithaKP @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.