GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — src: bootstrap prepare stack trace callback in shadow realm by legendecas · Pull Request #47107 · nodejs/node

Conversation

legendecas commented Mar 15, 2023

Copy link

Copy Markdown

Member

Bootstrap per-realm callbacks like prepare_stack_trace_callback in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction

legendecas added the realm Issues and PRs related to the ShadowRealm API and node::Realm. label

Mar 15, 2023

nodejs-github-bot commented Mar 15, 2023 •

edited by legendecas

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/startup
@nodejs/realm

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

lib / src

Issues and PRs involving general changes in the lib/ or src/ directories.

needs-ci PRs that need a full CI run. labels

Mar 15, 2023

anonrig approved these changes

Mar 15, 2023

View reviewed changes

joyeecheung reviewed

Mar 15, 2023

View reviewed changes

Comment thread

lib/internal/bootstrap/realm.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

test/parallel/test-shadow-realm-prepare-stack-trace.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

src/api/environment.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

legendecas force-pushed the shadow-realm/prepare-stack branch 2 times, most recently from 99977c5 to 86fd9e6 Compare

March 20, 2023 11:39

mcollina approved these changes

Mar 20, 2023

View reviewed changes

mcollina left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

legendecas force-pushed the shadow-realm/prepare-stack branch from 86fd9e6 to efc44cc Compare

March 29, 2023 17:57

joyeecheung approved these changes

Mar 29, 2023

View reviewed changes

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Mar 30, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Mar 30, 2023

nodejs-github-bot commented Mar 30, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50683/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Mar 30, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50695/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Mar 31, 2023

CI Reliability 2023-03-31 nodejs/reliability#535

Open

34 tasks

cjihrig approved these changes

Mar 31, 2023

View reviewed changes

cjihrig left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found myself needing this. LGTM once initializeWASI() is removed from pre_execution.js.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

jasnell approved these changes

Mar 31, 2023

View reviewed changes

github-actions Bot mentioned this pull request

Apr 1, 2023

CI Reliability 2023-04-01 nodejs/reliability#536

Open

38 tasks


          src: bootstrap prepare stack trace callback in shadow realm

571dadd

Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

legendecas force-pushed the shadow-realm/prepare-stack branch from 0f88844 to 571dadd Compare

April 2, 2023 09:46

legendecas commented Apr 2, 2023

Copy link

Copy Markdown

Member Author

Rebased and removed initializeWASI() changes.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Apr 2, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Apr 3, 2023

CI Reliability 2023-04-03 nodejs/reliability#538

Open

There was an error while loading. Please reload this page.

joyeecheung approved these changes

Apr 3, 2023

View reviewed changes

github-actions Bot mentioned this pull request

Apr 4, 2023

CI Reliability 2023-04-04 nodejs/reliability#539

Open

29 tasks

legendecas added the commit-queue PRs queued for automated landing through the Commit Queue. label

Apr 4, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Apr 4, 2023

nodejs-github-bot merged commit 3a014dc into nodejs:main

Apr 4, 2023

nodejs-github-bot commented Apr 4, 2023

Copy link

Copy Markdown

Collaborator

Landed in 3a014dc

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

legendecas deleted the shadow-realm/prepare-stack branch

April 4, 2023 02:04

github-actions Bot mentioned this pull request

Apr 5, 2023

CI Reliability 2023-04-05 nodejs/reliability#540

Open

26 tasks

RafaelGSS pushed a commit that referenced this pull request

Apr 5, 2023


          src: bootstrap prepare stack trace callback in shadow realm

122c7ff

Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

PR-URL: #47107
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>

RafaelGSS mentioned this pull request

Apr 6, 2023

v19.9.0 proposal #47441

Merged

RafaelGSS pushed a commit that referenced this pull request

Apr 6, 2023


          src: bootstrap prepare stack trace callback in shadow realm

21832b5

Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

PR-URL: #47107
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>

RafaelGSS commented Apr 7, 2023

Copy link

Copy Markdown

Member

Hi @legendecas! I had to drop #46809 and this PR isn't landing cleanly on v19.x-staging. Can you please create a manual backport? If it strictly depends on #46809 feel free to change the label to backport-blocked-v19.x.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS added the backport-requested-v19.x label

Apr 7, 2023

RafaelGSS mentioned this pull request

Apr 11, 2023

2023-04-18, Version 20.0.0 (Current) #47381

Merged

RafaelGSS pushed a commit that referenced this pull request

Apr 13, 2023


          src: bootstrap prepare stack trace callback in shadow realm

698508a

Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

PR-URL: #47107
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>

danielleadams added the backport-requested-v18.x label

Jun 12, 2023

targos pushed a commit that referenced this pull request

Nov 10, 2023


          src: bootstrap prepare stack trace callback in shadow realm

d35f870

Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

PR-URL: #47107
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>

targos mentioned this pull request

Nov 28, 2023

v18.19.0 release proposal #50953

Merged

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024


          src: bootstrap prepare stack trace callback in shadow realm

110bd4b

Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

PR-URL: nodejs/node#47107
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024


          src: bootstrap prepare stack trace callback in shadow realm

bf56be1

Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

PR-URL: nodejs/node#47107
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Reviewers

mcollina

mcollina approved these changes

jasnell

jasnell approved these changes

anonrig

anonrig approved these changes

cjihrig

cjihrig approved these changes

joyeecheung

joyeecheung approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++

Issues and PRs that require attention from people who are familiar with C++.

lib / src

Issues and PRs involving general changes in the lib/ or src/ directories.

needs-ci

PRs that need a full CI run.

realm

Issues and PRs related to the ShadowRealm API and node::Realm.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

legendecas commented Mar 15, 2023

Uh oh!

nodejs-github-bot commented Mar 15, 2023 • edited by legendecas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Mar 30, 2023

Uh oh!

nodejs-github-bot commented Mar 30, 2023

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

legendecas commented Apr 2, 2023

Uh oh!

nodejs-github-bot commented Apr 2, 2023

Uh oh!

nodejs-github-bot commented Apr 2, 2023

Uh oh!

nodejs-github-bot commented Apr 2, 2023

Uh oh!

nodejs-github-bot commented Apr 3, 2023

Uh oh!

nodejs-github-bot commented Apr 3, 2023

Uh oh!

nodejs-github-bot commented Apr 3, 2023

Uh oh!

nodejs-github-bot commented Apr 3, 2023

Uh oh!

nodejs-github-bot commented Apr 3, 2023

Uh oh!

legendecas commented Apr 3, 2023

Uh oh!

nodejs-github-bot commented Apr 4, 2023

Uh oh!

RafaelGSS commented Apr 7, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

nodejs-github-bot commented Mar 15, 2023 •

edited by legendecas

Loading

Uh oh!

There was an error while loading. Please reload this page.