GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — buffer: use private properties for brand checks in File by KhafraDev · Pull Request #47154 · nodejs/node

Conversation

@KhafraDev

@KhafraDev KhafraDev commented Mar 18, 2023

Copy link
Copy Markdown
Member

The current checks wouldn't work for certain values, and other places in the code have moved to this behavior as well.

import { File } from 'node:buffer'

const pd = Object.getOwnPropertyDescriptor(File.prototype, 'name')

pd.get.call(true) // Uncaught TypeError: Cannot use 'in' operator to search for '#name' in true

pd.get.call(null) // Uncaught TypeError [ERR_INVALID_THIS]: Value of "this" must be of type File

Refs: #46904

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@KhafraDev
buffer: use private properties for brand checks in File
393e443
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 18, 2023
@anonrig anonrig added semver-major PRs that contain breaking changes and should be released in the next major version. author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Mar 18, 2023
anonrig
anonrig approved these changes Mar 18, 2023
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50451/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig

anonrig commented Mar 19, 2023

Copy link
Copy Markdown
Member

Since, this change is done on an experimental API, I'll remove my tag of semver-major. If this is wrongly removed, please add it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 19, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50455/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Mar 19, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Mar 20, 2023
CI Reliability 2023-03-20 nodejs/reliability#530
Open
17 tasks
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 20, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 20, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 252a069 into nodejs:main Mar 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 20, 2023

Copy link
Copy Markdown
Collaborator

Landed in 252a069
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@KhafraDev
KhafraDev deleted the file-brand-checks branch March 20, 2023 22:22
@github-actions github-actions Bot mentioned this pull request Mar 21, 2023
CI Reliability 2023-03-21 nodejs/reliability#531
Open
19 tasks
@debadree25 debadree25 mentioned this pull request Mar 21, 2023
Flaky Test parallel/test-http-remove-connection-header-persists-connection #47200
Closed
@github-actions github-actions Bot mentioned this pull request Mar 22, 2023
CI Reliability 2023-03-22 nodejs/reliability#532
Open
19 tasks
@anonrig anonrig mentioned this pull request Mar 26, 2023
Improve webstreams brand validations #47218
Closed
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@KhafraDev @RafaelGSS
buffer: use private properties for brand checks in File
d639f2e 
PR-URL: #47154
Refs: #46904
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
v19.9.0 proposal #47441
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@KhafraDev @RafaelGSS
buffer: use private properties for brand checks in File
e3d98c3 
PR-URL: #47154
Refs: #46904
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@KhafraDev @danielleadams
buffer: use private properties for brand checks in File
4c69be4 
PR-URL: #47154
Refs: #46904
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Aug 13, 2026
feat(search): make large local corpora fast and fail-safe filocosta46/dotaios#80
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@KhafraDev @nodejs-github-bot @anonrig @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.