GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — doc: update `stream.reduce` concurrency note by rluvaton · Pull Request #47166 · nodejs/node Conversation
Member
At first, when I read that note I thought I should do this: import { Readable } from 'node:stream'; const totalViews = await Readable.from(videosUrl) .map((url) => url, { concurrency: 2 }) .reduce(async (total, url) => { const views = await getViewsAsync(url) total + views }, 0); console.log(totalViews); This did not work and does not make any sense as the map items are emitted in the order that got from the readable stream. So I thought of changing to note to recommend implementing reduce using @benjamingr, hope this is what you meant 😅
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
rluvaton
force-pushed
the
update-stream-operator-reduce-docs
branch
from
2a31082 to
4b92bfd
Compare
Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
rluvaton
force-pushed
the
update-stream-operator-reduce-docs
branch
2 times, most recently
from
2ac4139 to
487f5db
Compare
rluvaton
force-pushed
the
update-stream-operator-reduce-docs
branch
from
487f5db to
9627c88
Compare
rluvaton
commented
Comment on lines
2508
to
+2523
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated this example as well so the refactor can be more obvious
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
mcollina
approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. lgtm
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
VoltrexKeyva
approved these changes
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
RafaelGSS
pushed a commit
that referenced
this pull request
PR-URL: #47166 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
PR-URL: #47166 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
PR-URL: #47166 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
PR-URL: #47166 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers+1 more reviewerUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabelsProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |