GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: remove use of DEFAULT_ENCODING in PBKDF2 docs by tniessen · Pull Request #47181 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Mar 21, 2023

Copy link
Copy Markdown
Member

There is no point in documenting this legacy behavior, which will emit a warning when used.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss and lin72h reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@tniessen
doc: remove use of DEFAULT_ENCODING in PBKDF2 docs
14c9614
There is no point in documenting this legacy behavior, which will emit a
warning when used.
@tniessen tniessen added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to Node.js documentation. deprecations Issues and PRs related to deprecations. labels Mar 21, 2023
@tniessen

tniessen commented Mar 21, 2023

Copy link
Copy Markdown
Member Author

I opened this separately from #47182 so that this change can be backported. Ideally, this should land before #47182.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bnoordhuis
bnoordhuis approved these changes Mar 21, 2023
View reviewed changes
targos
targos approved these changes Mar 21, 2023
View reviewed changes
@tniessen tniessen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 21, 2023
panva
panva approved these changes Mar 21, 2023
View reviewed changes
lpinca
lpinca approved these changes Mar 21, 2023
View reviewed changes
@tniessen tniessen added the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 23, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 002b30e into nodejs:main Mar 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in 002b30e

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@tniessen @RafaelGSS
doc: remove use of DEFAULT_ENCODING in PBKDF2 docs
7e3eacc
There is no point in documenting this legacy behavior, which will emit a
warning when used.

PR-URL: #47181
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
v19.9.0 proposal #47441
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@tniessen @RafaelGSS
doc: remove use of DEFAULT_ENCODING in PBKDF2 docs
36c118b
There is no point in documenting this legacy behavior, which will emit a
warning when used.

PR-URL: #47181
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@tniessen @danielleadams
doc: remove use of DEFAULT_ENCODING in PBKDF2 docs
1e97ccd
There is no point in documenting this legacy behavior, which will emit a
warning when used.

PR-URL: #47181
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes
@bnoordhuis bnoordhuis bnoordhuis approved these changes
@lpinca lpinca lpinca approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. crypto Issues and PRs related to the crypto subsystem. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@tniessen @nodejs-github-bot @panva @bnoordhuis @lpinca @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.