GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: document process for sharing project news by mhdawson · Pull Request #47189 · nodejs/node

Conversation

@mhdawson

@mhdawson mhdawson commented Mar 21, 2023

Copy link
Copy Markdown
Member

Fixes: nodejs/TSC#1333

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhdawson
doc: document process for sharing project news
d6bd72c 
Fixes: nodejs/TSC#1333

Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Mar 21, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Mar 21, 2023
mscdex
mscdex reviewed Mar 21, 2023
View reviewed changes
Comment thread doc/contributing/sharing-project-news.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
gireeshpunathil
gireeshpunathil approved these changes Mar 21, 2023
View reviewed changes
Comment thread doc/contributing/sharing-project-news.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
mscdex
mscdex reviewed Mar 21, 2023
View reviewed changes
Comment thread doc/contributing/sharing-project-news.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
mscdex
mscdex reviewed Mar 21, 2023
View reviewed changes
Comment thread doc/contributing/sharing-project-news.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
mscdex
mscdex reviewed Mar 21, 2023
View reviewed changes
Comment thread doc/contributing/sharing-project-news.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
legendecas
legendecas approved these changes Mar 22, 2023
View reviewed changes
VoltrexKeyva
VoltrexKeyva reviewed Mar 22, 2023
View reviewed changes
Comment thread doc/contributing/sharing-project-news.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
aymen94
aymen94 approved these changes Mar 22, 2023
View reviewed changes
mhdawson and others added 6 commits March 22, 2023 16:30
@mhdawson @mscdex
Update doc/contributing/sharing-project-news.md
293b0d3 
Co-authored-by: mscdex <[email protected]>
@mhdawson @gireeshpunathil
Update doc/contributing/sharing-project-news.md
369cf1a 
Co-authored-by: Gireesh Punathil <[email protected]>
@mhdawson @mscdex
Update doc/contributing/sharing-project-news.md
e1acbd0 
Co-authored-by: mscdex <[email protected]>
@mhdawson @mscdex
Update doc/contributing/sharing-project-news.md
d452967 
Co-authored-by: mscdex <[email protected]>
@mhdawson @mscdex
Update doc/contributing/sharing-project-news.md
64175e1 
Co-authored-by: mscdex <[email protected]>
@mhdawson
address comments
d75eaea
Trott
Trott reviewed Mar 24, 2023
View reviewed changes
Comment thread doc/contributing/sharing-project-news.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott reviewed Mar 24, 2023
View reviewed changes
Comment thread doc/contributing/sharing-project-news.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott reviewed Mar 24, 2023
View reviewed changes
Comment thread doc/contributing/sharing-project-news.md Outdated

The project's approach is as follows:

* The project will create one "What's new in YYYY" issue in the `nodejs/node`

@Trott Trott Mar 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An issue seems like the wrong tool for the job. Would a GitHub discussion item be better?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@mhdawson mhdawson Mar 24, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm if ok if a discussion item is better for the core repo. Updating

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhdawson @Trott
Update doc/contributing/sharing-project-news.md
dc0db2c 
Co-authored-by: Rich Trott <[email protected]>
mhdawson
mhdawson commented Mar 24, 2023
View reviewed changes
Comment thread doc/contributing/sharing-project-news.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
mhdawson added 2 commits March 24, 2023 09:05
@mhdawson
Update doc/contributing/sharing-project-news.md
5014723
@mhdawson
squash: address comments
0ff4e46
@mhdawson

mhdawson commented Mar 24, 2023

Copy link
Copy Markdown
Member Author

@Trott believe I've addressed your comments/suggestions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Mar 26, 2023
View reviewed changes
mcollina
mcollina reviewed Mar 28, 2023
View reviewed changes
Comment thread doc/contributing/sharing-project-news.md
The project's approach is as follows:

* The project will create one "What's new in YYYY" discussion item in
the `nodejs/node` repo for news related to Node.js core.

@mcollina mcollina Mar 28, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be better to use a separate repo for these news. In this way, publications could subscribe to the notifications on that repository to receive the updates.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@mhdawson mhdawson Mar 28, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could make it easier for publications but the goal is to make it easy for the teams and the project both in terms of workflow and discoverability. In the case of the node-api team looking for an issue in a different repo would be more work due to the way we use a milestone to review work each week.

Even if there was a separate repo the ask was not that a new issue be created for each piece of news, only update an existing issue/discussion so once the publication subscribes to an issue I don't think it will be any different in respect to notifications.

Therefore I think using an issue/discussion item in the existing repos is better.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina reacted with heart emoji
All reactions
  • ❤️ 1 reaction

@mcollina mcollina Mar 28, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhdawson mhdawson mentioned this pull request Mar 29, 2023
Create Communications Channel to JS Newsletters/Periodicals nodejs/next-10#110
Open
4 tasks
mhdawson added a commit that referenced this pull request Mar 29, 2023
@mhdawson
doc: document process for sharing project news
67660e8 
Fixes: nodejs/TSC#1333

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #47189
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@mhdawson

mhdawson commented Mar 29, 2023

Copy link
Copy Markdown
Member Author

Landed in 67660e8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson closed this Mar 29, 2023
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@mhdawson @RafaelGSS
doc: document process for sharing project news
dd96588 
Fixes: nodejs/TSC#1333

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #47189
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
v19.9.0 proposal #47441
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@mhdawson @RafaelGSS
doc: document process for sharing project news
81a045e 
Fixes: nodejs/TSC#1333

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #47189
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@mhdawson @RafaelGSS
doc: document process for sharing project news
296577a 
Fixes: nodejs/TSC#1333

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #47189
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@mhdawson @danielleadams
doc: document process for sharing project news
c722720 
Fixes: nodejs/TSC#1333

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #47189
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina left review comments
@Trott Trott Trott left review comments
@lpinca lpinca lpinca approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@legendecas legendecas legendecas approved these changes
+3 more reviewers
@mscdex mscdex mscdex left review comments
@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sharing project news

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@mhdawson @nodejs-github-bot @mcollina @mscdex @Trott @lpinca @gireeshpunathil @legendecas @aymen94 @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.