GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — meta: update link to collaborators discussion page by targos · Pull Request #47211 · nodejs/node

Conversation

@targos

@targos targos commented Mar 22, 2023

Copy link
Copy Markdown
Member

Refs: nodejs/TSC#1340

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@targos
meta: update link to collaborators discussion page
93d5827
Refs: nodejs/TSC#1340
@nodejs-github-bot

nodejs-github-bot commented Mar 22, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 22, 2023
VoltrexKeyva
VoltrexKeyva reviewed Mar 22, 2023
View reviewed changes
Comment thread GOVERNANCE.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

targos
targos commented Mar 22, 2023
View reviewed changes
Comment thread GOVERNANCE.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@targos
Update GOVERNANCE.md
599dab3
richardlau
richardlau approved these changes Mar 22, 2023
View reviewed changes
lpinca
lpinca approved these changes Mar 22, 2023
View reviewed changes
mhdawson
mhdawson approved these changes Mar 22, 2023
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
RaisinTen
RaisinTen approved these changes Mar 23, 2023
View reviewed changes
RafaelGSS
RafaelGSS approved these changes Mar 23, 2023
View reviewed changes
Trott
Trott approved these changes Mar 24, 2023
View reviewed changes
@targos targos added the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 25, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 25, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/47211
✔  Done loading data for nodejs/node/pull/47211
----------------------------------- PR info ------------------------------------
Title      meta: update link to collaborators discussion page (#47211)
Author     Michaël Zasso  (@targos)
Branch     targos:nomination -> nodejs:main
Labels     meta
Commits    2
 - meta: update link to collaborators discussion page
 - Update GOVERNANCE.md
Committers 2
 - Michaël Zasso 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/47211
Refs: https://github.com/nodejs/TSC/issues/1340
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson 
Reviewed-By: Darshan Sen 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Rich Trott 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47211
Refs: https://github.com/nodejs/TSC/issues/1340
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson 
Reviewed-By: Darshan Sen 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Rich Trott 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 22 Mar 2023 10:36:39 GMT
   ✔  Approvals: 6
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47211#pullrequestreview-1352768966
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47211#pullrequestreview-1353437393
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/47211#pullrequestreview-1353455553
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/47211#pullrequestreview-1353969775
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47211#pullrequestreview-1354315516
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/47211#pullrequestreview-1355941254
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 47211
From https://github.com/nodejs/node
 * branch                  refs/pull/47211/merge -> FETCH_HEAD
✔  Fetched commits as 94ec71d38583..599dab364ba8
--------------------------------------------------------------------------------
[main 28f186f559] meta: update link to collaborators discussion page
 Author: Michaël Zasso 
 Date: Wed Mar 22 11:35:51 2023 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 5e41fedb4a] Update GOVERNANCE.md
 Author: Michaël Zasso 
 Date: Wed Mar 22 13:32:03 2023 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
⚠ Found Refs: nodejs/TSC#1340, skipping..
--------------------------------- New Message ----------------------------------
meta: update link to collaborators discussion page

Refs: nodejs/TSC#1340
PR-URL: #47211
Reviewed-By: Richard Lau [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Michael Dawson [email protected]
Reviewed-By: Darshan Sen [email protected]
Reviewed-By: Rafael Gonzaga [email protected]
Reviewed-By: Rich Trott [email protected]

[detached HEAD 821a778356] meta: update link to collaborators discussion page
Author: Michaël Zasso [email protected]
Date: Wed Mar 22 11:35:51 2023 +0100
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update GOVERNANCE.md

PR-URL: #47211
Refs: nodejs/TSC#1340
Reviewed-By: Richard Lau [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Michael Dawson [email protected]
Reviewed-By: Darshan Sen [email protected]
Reviewed-By: Rafael Gonzaga [email protected]
Reviewed-By: Rich Trott [email protected]

[detached HEAD 2063ea4798] Update GOVERNANCE.md
Author: Michaël Zasso [email protected]
Date: Wed Mar 22 13:32:03 2023 +0100
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/4519020911

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Mar 25, 2023
@targos targos added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Mar 25, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 06c91af into nodejs:main Mar 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in 06c91af

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@targos @RafaelGSS
meta: update link to collaborators discussion page
138db9f
Refs: nodejs/TSC#1340
PR-URL: #47211
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
v19.9.0 proposal #47441
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@targos @RafaelGSS
meta: update link to collaborators discussion page
44a767e
Refs: nodejs/TSC#1340
PR-URL: #47211
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@targos @RafaelGSS
meta: update link to collaborators discussion page
22b9acd
Refs: nodejs/TSC#1340
PR-URL: #47211
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos
targos deleted the nomination branch April 28, 2023 15:24
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@targos @danielleadams
meta: update link to collaborators discussion page
1f08f48
Refs: nodejs/TSC#1340
PR-URL: #47211
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+2 more reviewers
@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@targos @nodejs-github-bot @Trott @lpinca @richardlau @mhdawson @RafaelGSS @RaisinTen @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.