GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: V8: cherry-pick 215ccd593edb by joyeecheung · Pull Request #47212 · nodejs/node

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Mar 22, 2023

Copy link
Copy Markdown
Member

Currently ./configure --v8-non-optimized-debug is broken without this patch, which makes debugging into V8 harder. The upstream works fine without this probably because there V8 is always built using a specified version of clang but for Node.js we need to float this until the patch gets in with the next V8 update.

Original commit message:

Use FlagValue::value() in SLOW_DCHECK

Previously SLOW_DCHECK used the non-constexpr bool() operator
of FlagValue, which cannot be used in constexpr. Switch to
FlagValue::value() instead for make it compile in constexpr.

Change-Id: I3e4f70d82c0027cf56999b6c4639479606151696
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4341495
Reviewed-by: Jakob Linke <[email protected]>
Commit-Queue: Joyee Cheung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#86611}

Refs: v8/v8@215ccd5

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@joyeecheung
deps: V8: cherry-pick 215ccd593edb
7a3bb74 
Original commit message:

    Use FlagValue::value() in SLOW_DCHECK

    Previously SLOW_DCHECK used the non-constexpr bool() operator
    of FlagValue, which cannot be used in constexpr. Switch to
    FlagValue::value() instead for make it compile in constexpr.

    Change-Id: I3e4f70d82c0027cf56999b6c4639479606151696
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4341495
    Reviewed-by: Jakob Linke <[email protected]>
    Commit-Queue: Joyee Cheung <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#86611}

Refs: v8/v8@215ccd5
@nodejs-github-bot

nodejs-github-bot commented Mar 22, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Mar 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 22, 2023 •
edited by joyeecheung
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50543/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/5235/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 22, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5235/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 22, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5235/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Mar 22, 2023
View reviewed changes
debadree25
debadree25 reviewed Mar 22, 2023
View reviewed changes
Comment thread common.gypi Resolved

Uh oh!

There was an error while loading. Please reload this page.
debadree25
debadree25 approved these changes Mar 22, 2023
View reviewed changes
richardlau
richardlau approved these changes Mar 22, 2023
View reviewed changes
@joyeecheung joyeecheung added the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 24, 2023
@nodejs-github-bot
nodejs-github-bot merged commit f523979 into nodejs:main Mar 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 24, 2023

Copy link
Copy Markdown
Collaborator

Landed in f523979
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@joyeecheung @RafaelGSS
deps: V8: cherry-pick 215ccd593edb
f747bd5 
Original commit message:

    Use FlagValue::value() in SLOW_DCHECK

    Previously SLOW_DCHECK used the non-constexpr bool() operator
    of FlagValue, which cannot be used in constexpr. Switch to
    FlagValue::value() instead for make it compile in constexpr.

    Change-Id: I3e4f70d82c0027cf56999b6c4639479606151696
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4341495
    Reviewed-by: Jakob Linke <[email protected]>
    Commit-Queue: Joyee Cheung <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#86611}

Refs: v8/v8@215ccd5
PR-URL: #47212
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
v19.9.0 proposal #47441
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@joyeecheung @RafaelGSS
deps: V8: cherry-pick 215ccd593edb
9a12e0d 
Original commit message:

    Use FlagValue::value() in SLOW_DCHECK

    Previously SLOW_DCHECK used the non-constexpr bool() operator
    of FlagValue, which cannot be used in constexpr. Switch to
    FlagValue::value() instead for make it compile in constexpr.

    Change-Id: I3e4f70d82c0027cf56999b6c4639479606151696
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4341495
    Reviewed-by: Jakob Linke <[email protected]>
    Commit-Queue: Joyee Cheung <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#86611}

Refs: v8/v8@215ccd5
PR-URL: #47212
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@joyeecheung @RafaelGSS
deps: V8: cherry-pick 215ccd593edb
7a4beaa 
Original commit message:

    Use FlagValue::value() in SLOW_DCHECK

    Previously SLOW_DCHECK used the non-constexpr bool() operator
    of FlagValue, which cannot be used in constexpr. Switch to
    FlagValue::value() instead for make it compile in constexpr.

    Change-Id: I3e4f70d82c0027cf56999b6c4639479606151696
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4341495
    Reviewed-by: Jakob Linke <[email protected]>
    Commit-Queue: Joyee Cheung <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#86611}

Refs: v8/v8@215ccd5
PR-URL: #47212
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@danielleadams danielleadams added the dont-land-on-v18.x label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes
+2 more reviewers
@targos targos targos approved these changes
@debadree25 debadree25 debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@joyeecheung @nodejs-github-bot @targos @richardlau @debadree25 @danielleadams
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.