GeezerVison

Copy link

Copy Markdown

Member

Trott marked this pull request as ready for review March 28, 2023 18:51

richardlau approved these changes Mar 28, 2023

View reviewed changes

MoLow approved these changes Mar 28, 2023

View reviewed changes

tniessen approved these changes Mar 28, 2023

View reviewed changes

mhdawson approved these changes Mar 28, 2023

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

anonrig approved these changes Mar 28, 2023

View reviewed changes

- Loading data for nodejs/node/pull/47285
✔  Done loading data for nodejs/node/pull/47285
----------------------------------- PR info ------------------------------------
Title      tools: update codecov branch (#47285)
Author     Rich Trott  (@Trott)
Branch     Trott:codecov -> nodejs:main
Labels     fast-track
Commits    1
 - tools: update codecov branch
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/47285
Reviewed-By: Richard Lau 
Reviewed-By: Moshe Atlow 
Reviewed-By: Tobias Nießen 
Reviewed-By: Michael Dawson 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47285
Reviewed-By: Richard Lau 
Reviewed-By: Moshe Atlow 
Reviewed-By: Tobias Nießen 
Reviewed-By: Michael Dawson 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 28 Mar 2023 18:51:43 GMT
   ✔  Approvals: 5
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47285#pullrequestreview-1361728795
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/47285#pullrequestreview-1361734226
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/47285#pullrequestreview-1361740131
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/47285#pullrequestreview-1361766478
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47285#pullrequestreview-1362075227
   ℹ  This PR is being fast-tracked
   ✘  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

Trott force-pushed the codecov branch from d3ad6d3 to 786a718 Compare March 29, 2023 02:06

Trott deleted the codecov branch March 29, 2023 02:06

[
  {
    __typename: 'StatusContext',
    context: 'codecov/project',
    description: '89.48% (-0.03%) compared to 09a4bb1',
    targetUrl: 'https://codecov.io/gh/nodejs/node/pull/47285'
  },
  {
    __typename: 'StatusContext',
    context: 'codecov/patch',
    description: 'Coverage not affected when comparing 09a4bb1...786a718',
    targetUrl: 'https://codecov.io/gh/nodejs/node/pull/47285'
  }
]

We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: nodejs#47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status

We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: #47306
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Codecov is still using the old default branch. Update it to "main", the
current default branch. I'm not sure why it's not picking it up
automatically or if there is a way to ask it to refresh, but setting it
in codecov.yml should resolve the issue.

PR-URL: #47285
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>

We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: #47306
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Codecov is still using the old default branch. Update it to "main", the
current default branch. I'm not sure why it's not picking it up
automatically or if there is a way to ask it to refresh, but setting it
in codecov.yml should resolve the issue.

PR-URL: #47285
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>

We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: #47306
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Codecov is still using the old default branch. Update it to "main", the
current default branch. I'm not sure why it's not picking it up
automatically or if there is a way to ask it to refresh, but setting it
in codecov.yml should resolve the issue.

PR-URL: #47285
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>

We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: #47306
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>

We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: #47306
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Codecov is still using the old default branch. Update it to "main", the
current default branch. I'm not sure why it's not picking it up
automatically or if there is a way to ask it to refresh, but setting it
in codecov.yml should resolve the issue.

PR-URL: #47285
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>

We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: #47306
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>

We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: nodejs#47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: nodejs#47306
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>