GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Explaining that vm.SourceTextModule() is able to evaluate in current … by axkibe · Pull Request #47295 · nodejs/node

Conversation

@axkibe

@axkibe axkibe commented Mar 29, 2023 •
edited by deokjinkim
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Covers my feature request that is already implemented, just not documented.

Fixes: #47280

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. vm Issues and PRs related to the vm subsystem. labels Mar 29, 2023
debadree25
debadree25 reviewed Mar 29, 2023
View reviewed changes

@debadree25 debadree25 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for your contribution, could you just rebase and update the commit message to adhere to the guidelines https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines

Thank You!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Axel Kittenberger
doc: vm.SourceTextModule() without context option
b2ca2b2 
Explaining that vm.SourceTextModule() is able to evaluate in current
context if non is given

Fixes: #47280
@axkibe

axkibe commented Mar 29, 2023

Copy link
Copy Markdown
Contributor Author

I changed the message by force pushing to my fork if thats okay.
debadree25 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@debadree25

debadree25 commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

That is not a problem!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
debadree25
debadree25 approved these changes Mar 29, 2023
View reviewed changes
@debadree25

debadree25 commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

Also cc @nodejs/vm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@debadree25 debadree25 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 29, 2023
lpinca
lpinca approved these changes Mar 29, 2023
View reviewed changes
bnoordhuis
bnoordhuis approved these changes Mar 29, 2023
View reviewed changes
@debadree25 debadree25 added the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 30, 2023
legendecas
legendecas approved these changes Mar 31, 2023
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 31, 2023
@nodejs-github-bot
nodejs-github-bot merged commit b74b9dd into nodejs:main Mar 31, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator

Landed in b74b9dd
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@axkibe @RafaelGSS
doc: vm.SourceTextModule() without context option
ca9f0f0 
Explaining that vm.SourceTextModule() is able to evaluate in current
context if non is given

Fixes: #47280
PR-URL: #47295
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
v19.9.0 proposal #47441
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@axkibe @RafaelGSS
doc: vm.SourceTextModule() without context option
353c626 
Explaining that vm.SourceTextModule() is able to evaluate in current
context if non is given

Fixes: #47280
PR-URL: #47295
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@axkibe @RafaelGSS
doc: vm.SourceTextModule() without context option
958d5f3 
Explaining that vm.SourceTextModule() is able to evaluate in current
context if non is given

Fixes: #47280
PR-URL: #47295
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@axkibe @RafaelGSS
doc: vm.SourceTextModule() without context option
1c21fbf 
Explaining that vm.SourceTextModule() is able to evaluate in current
context if non is given

Fixes: #47280
PR-URL: #47295
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@axkibe @danielleadams
doc: vm.SourceTextModule() without context option
ece029f 
Explaining that vm.SourceTextModule() is able to evaluate in current
context if non is given

Fixes: #47280
PR-URL: #47295
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@lpinca lpinca lpinca approved these changes
@legendecas legendecas legendecas approved these changes
+1 more reviewer
@debadree25 debadree25 debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

running vm.SourceTextModule in thisContext

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@axkibe @debadree25 @nodejs-github-bot @bnoordhuis @lpinca @legendecas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.