GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — sea: fix memory leak detected by asan by RaisinTen · Pull Request #47309 · nodejs/node

Conversation

@RaisinTen

@RaisinTen RaisinTen commented Mar 30, 2023

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tony-go and bricss reacted with rocket emoji
All reactions
  • 🚀 2 reactions
@RaisinTen
sea: fix memory leak detected by asan
e1cf8bd 
Signed-off-by: Darshan Sen <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/single-executable
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications. labels Mar 30, 2023
@RaisinTen RaisinTen added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 30, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 30, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
anonrig
anonrig approved these changes Mar 30, 2023
View reviewed changes
@RaisinTen RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 30, 2023
cjihrig
cjihrig approved these changes Mar 30, 2023
View reviewed changes
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
tony-go
tony-go approved these changes Mar 30, 2023
View reviewed changes
VoltrexKeyva
VoltrexKeyva approved these changes Mar 30, 2023
View reviewed changes
joyeecheung
joyeecheung approved these changes Mar 30, 2023
View reviewed changes
Comment thread src/node_sea.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen
sea: refactor code to be easier to read
d12133c 
Refs: nodejs#47309 (comment)
Signed-off-by: Darshan Sen <[email protected]>
@RaisinTen RaisinTen added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Mar 30, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 30, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
mhdawson
mhdawson approved these changes Mar 30, 2023
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot mentioned this pull request Mar 31, 2023
CI Reliability 2023-03-31 nodejs/reliability#535
Open
34 tasks
@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50729/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aymen94
aymen94 approved these changes Mar 31, 2023
View reviewed changes
jasnell
jasnell approved these changes Mar 31, 2023
View reviewed changes
This was referenced Apr 1, 2023
CI Reliability 2023-04-01 nodejs/reliability#536
Open
CI Reliability 2023-04-02 nodejs/reliability#537
Open
@RaisinTen RaisinTen added the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 3, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 3, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 5db08cf into nodejs:main Apr 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 3, 2023

Copy link
Copy Markdown
Collaborator

Landed in 5db08cf
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen
RaisinTen deleted the sea-fix-memory-leak-detected-by-asan branch April 3, 2023 08:10
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@RaisinTen @RafaelGSS
sea: fix memory leak detected by asan
193e12b 
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #47309
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
v19.9.0 proposal #47441
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@RaisinTen @RafaelGSS
sea: fix memory leak detected by asan
071929b 
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #47309
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@RaisinTen @RafaelGSS
sea: fix memory leak detected by asan
54e35a8 
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #47309
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@RaisinTen @RafaelGSS
sea: fix memory leak detected by asan
33b0906 
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #47309
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@RaisinTen @danielleadams
sea: fix memory leak detected by asan
0621bdb 
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #47309
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@RaisinTen @MoLow
sea: fix memory leak detected by asan
7306b0f 
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: nodejs#47309
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@anonrig anonrig anonrig approved these changes
@cjihrig cjihrig cjihrig approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
+4 more reviewers
@mhdawson mhdawson mhdawson approved these changes
@aymen94 aymen94 aymen94 approved these changes
@tony-go tony-go tony-go approved these changes
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@RaisinTen @nodejs-github-bot @jasnell @anonrig @cjihrig @joyeecheung @mhdawson @aymen94 @tony-go @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.