GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — blob: fix range error with many chunks by KhafraDev · Pull Request #47320 · nodejs/node

Conversation

@KhafraDev

@KhafraDev KhafraDev commented Mar 30, 2023

Copy link
Copy Markdown
Member

Fixes #47301

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 30, 2023
@KhafraDev
buffer: fix blob range error with many chunks
0a01d13
@KhafraDev
KhafraDev force-pushed the blob-range-error branch from c8aaac0 to 0a01d13 Compare March 30, 2023 14:44
jasnell
jasnell approved these changes Mar 30, 2023
View reviewed changes
@jasnell

jasnell commented Mar 30, 2023

Copy link
Copy Markdown
Member

Thank you!
KhafraDev reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Mar 30, 2023
View reviewed changes
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Mar 30, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 30, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50709/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
VoltrexKeyva
VoltrexKeyva approved these changes Mar 30, 2023
View reviewed changes
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 30, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 1, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 85705a4 into nodejs:main Apr 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2023

Copy link
Copy Markdown
Collaborator

Landed in 85705a4
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@KhafraDev
KhafraDev deleted the blob-range-error branch April 1, 2023 14:53
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@KhafraDev @RafaelGSS
buffer: fix blob range error with many chunks
d149a45 
PR-URL: #47320
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
v19.9.0 proposal #47441
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@KhafraDev @RafaelGSS
buffer: fix blob range error with many chunks
6e497d4 
PR-URL: #47320
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@KhafraDev @RafaelGSS
buffer: fix blob range error with many chunks
3f0061c 
PR-URL: #47320
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@travis travis mentioned this pull request Apr 7, 2023
uploading large files on node v19.8.0 pops the stack storacha/w3up#641
Closed
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@KhafraDev @RafaelGSS
buffer: fix blob range error with many chunks
23a69d9 
PR-URL: #47320
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@danielleadams danielleadams added the dont-land-on-v18.x label Jun 12, 2023
@rluvaton rluvaton mentioned this pull request Sep 26, 2023
Blob.text and Blob.arraybuffer are 10x+ slower on 20.x nodejs/performance#118
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@anonrig anonrig anonrig approved these changes
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Blob regression in v19.8.x

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@KhafraDev @jasnell @nodejs-github-bot @anonrig @VoltrexKeyva @danielleadams
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.