GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — benchmark: lower URL.canParse runs by KhafraDev · Pull Request #47351 · nodejs/node

Conversation

@KhafraDev

@KhafraDev KhafraDev commented Mar 31, 2023

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@KhafraDev
benchmark: lower URL.canParse runs
4f541e2
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. url Issues and PRs related to the legacy built-in url module. labels Mar 31, 2023
anonrig
anonrig approved these changes Mar 31, 2023
View reviewed changes
@anonrig anonrig added fast-track PRs proposed for a shorter-than-standard waiting period before landing. author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Mar 31, 2023
@github-actions

github-actions Bot commented Mar 31, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.
anonrig, Qard, debadree25, and jasnell reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 31, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
Qard
Qard approved these changes Mar 31, 2023
View reviewed changes
@anonrig

anonrig commented Mar 31, 2023

Copy link
Copy Markdown
Member

Cancelled Jenkins jobs since it's not required. We can merge this when the Github CI is green.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Mar 31, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50771/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig

anonrig commented Mar 31, 2023

Copy link
Copy Markdown
Member

Landed on a346b97
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig closed this Mar 31, 2023
@KhafraDev
KhafraDev deleted the canparse-lower-benchmark-n branch March 31, 2023 23:17
@richardlau

richardlau commented Apr 1, 2023

Copy link
Copy Markdown
Member

Landed on a346b97

@anonrig This commit appears to be missing metadata.
anonrig reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott pushed a commit that referenced this pull request Apr 1, 2023
@KhafraDev @Trott
benchmark: lower URL.canParse runs
39a08ee 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott

Trott commented Apr 1, 2023

Copy link
Copy Markdown
Member

Landed on a346b97

@anonrig This commit appears to be missing metadata.

I ran git node metadata 47351, pasted the resulting metadata into git amend, ran core-validate-commit to make sure all was well, and force-pushed to fix.
richardlau and anonrig reacted with thumbs up emoji anonrig reacted with heart emoji
All reactions
  • 👍 2 reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig

anonrig commented Apr 1, 2023

Copy link
Copy Markdown
Member

Thank you @Trott and @richardlau
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Apr 2, 2023
CI Reliability 2023-04-02 nodejs/reliability#537
Open
CI Reliability 2023-04-03 nodejs/reliability#538
Open
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@KhafraDev @RafaelGSS
benchmark: lower URL.canParse runs
97eb796 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
v19.9.0 proposal #47441
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@KhafraDev @RafaelGSS
benchmark: lower URL.canParse runs
8a8a40c 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@KhafraDev @RafaelGSS
benchmark: lower URL.canParse runs
48f6a67 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@KhafraDev @RafaelGSS
benchmark: lower URL.canParse runs
6a4076a 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@KhafraDev @danielleadams
benchmark: lower URL.canParse runs
a72780e 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MoLow

MoLow commented Jul 6, 2023

Copy link
Copy Markdown
Member

@danielleadams this was accidentally pushed to v18.x-staging - a72780e but is blocked by #47179
danielleadams reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow added the backport-blocked-v18.x label Jul 6, 2023
@MoLow MoLow mentioned this pull request Jul 6, 2023
benchmark: differentiate whatwg and legacy url #47377
Merged
targos pushed a commit that referenced this pull request Nov 10, 2023
@KhafraDev @targos
benchmark: lower URL.canParse runs
3d7734c 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
benchmark: lower URL.canParse runs
5c6a735 
PR-URL: nodejs/node#47351
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
benchmark: lower URL.canParse runs
f69376e 
PR-URL: nodejs/node#47351
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qard Qard Qard approved these changes
@jasnell jasnell jasnell approved these changes
@anonrig anonrig anonrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. fast-track PRs proposed for a shorter-than-standard waiting period before landing. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@KhafraDev @nodejs-github-bot @anonrig @richardlau @Trott @MoLow @Qard @jasnell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.