GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: move test-shadow-realm-gc.js to known_issues by joyeecheung · Pull Request #47355 · nodejs/node

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Apr 1, 2023

Copy link
Copy Markdown
Member

There is actually a leak. The test doesn't exercise the right path to create a substantial enough object graph (e.g. accessing something that results in the loading of a binding). This does something more complicated in the test and moves it to known_issues until we find a fix.

Refs: #47353

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@joyeecheung
test: move test-shadow-realm-gc.js to known_issues
4e89ddb 
There is actually a leak. The test doesn't exercise the right
path to create a substantial enough object graph (e.g.
accessing something that results in the loading of a binding).
This does something more complicated in the test and moves it
to known_issues until we find a fix.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Apr 1, 2023
@anonrig

anonrig commented Apr 1, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

known_issues expect the test to fail, but it just throws OOM exception causing the test runner to fail. Can we update & fast-track this, to merge Ada pull-request?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
legendecas
legendecas reviewed Apr 2, 2023
View reviewed changes
Comment thread test/known_issues/test-shadow-realm-gc.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung
fixup! test: move test-shadow-realm-gc.js to known_issues
2b9c917
@nodejs-github-bot

nodejs-github-bot commented Apr 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50873/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Apr 3, 2023
View reviewed changes
legendecas
legendecas approved these changes Apr 3, 2023
View reviewed changes
Comment thread test/known_issues/test-shadow-realm-gc.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Apr 3, 2023
View reviewed changes
@joyeecheung @legendecas
fixup! test: move test-shadow-realm-gc.js to known_issues
e0ea347 
Co-authored-by: Chengzhong Wu <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Apr 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50879/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50885/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Apr 4, 2023
CI Reliability 2023-04-04 nodejs/reliability#539
Open
29 tasks
@legendecas legendecas added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. labels Apr 4, 2023
legendecas
legendecas approved these changes Apr 4, 2023
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 4, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 0361978 into nodejs:main Apr 4, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

Landed in 0361978
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Apr 5, 2023
CI Reliability 2023-04-05 nodejs/reliability#540
Open
26 tasks
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@joyeecheung @RafaelGSS
test: move test-shadow-realm-gc.js to known_issues
8e91659 
There is actually a leak. The test doesn't exercise the right
path to create a substantial enough object graph (e.g.
accessing something that results in the loading of a binding).
This does something more complicated in the test and moves it
to known_issues until we find a fix.

PR-URL: #47355
Refs: #47353
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
v19.9.0 proposal #47441
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@joyeecheung @RafaelGSS
test: move test-shadow-realm-gc.js to known_issues
6d0b61d 
There is actually a leak. The test doesn't exercise the right
path to create a substantial enough object graph (e.g.
accessing something that results in the loading of a binding).
This does something more complicated in the test and moves it
to known_issues until we find a fix.

PR-URL: #47355
Refs: #47353
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS added the backport-blocked-v19.x label Apr 7, 2023
@RafaelGSS

RafaelGSS commented Apr 7, 2023

Copy link
Copy Markdown
Member

Hi @joyeecheung! This commit didn't land cleanly on v19.x-staging because there are no test-shadow-realm-gc.js (due to commit drops). Can you please create a manual backport? I'm adding the backport-blocked label because it depends on #46809
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS mentioned this pull request Apr 11, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
legendecas pushed a commit to legendecas/node that referenced this pull request Apr 12, 2023
@joyeecheung @legendecas
test: move test-shadow-realm-gc.js to known_issues
7c77f71 
There is actually a leak. The test doesn't exercise the right
path to create a substantial enough object graph (e.g.
accessing something that results in the loading of a binding).
This does something more complicated in the test and moves it
to known_issues until we find a fix.

PR-URL: nodejs#47355
Refs: nodejs#47353
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@legendecas legendecas mentioned this pull request Apr 12, 2023
[v19.x] src: bootstrap Web [Exposed=*] APIs in the shadow realm #47530
Closed
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
@joyeecheung @RafaelGSS
test: move test-shadow-realm-gc.js to known_issues
23f66b1 
There is actually a leak. The test doesn't exercise the right
path to create a substantial enough object graph (e.g.
accessing something that results in the loading of a binding).
This does something more complicated in the test and moves it
to known_issues until we find a fix.

PR-URL: #47355
Refs: #47353
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@joyeecheung @danielleadams
test: move test-shadow-realm-gc.js to known_issues
0da5c65 
There is actually a leak. The test doesn't exercise the right
path to create a substantial enough object graph (e.g.
accessing something that results in the loading of a binding).
This does something more complicated in the test and moves it
to known_issues until we find a fix.

PR-URL: #47355
Refs: #47353
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@joyeecheung @MoLow
test: move test-shadow-realm-gc.js to known_issues
44f08ed 
There is actually a leak. The test doesn't exercise the right
path to create a substantial enough object graph (e.g.
accessing something that results in the loading of a binding).
This does something more complicated in the test and moves it
to known_issues until we find a fix.

PR-URL: nodejs#47355
Refs: nodejs#47353
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@cjihrig cjihrig cjihrig approved these changes
@legendecas legendecas legendecas approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@joyeecheung @anonrig @nodejs-github-bot @RafaelGSS @cjihrig @legendecas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.