GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — test_runner: color errors only when colors are avilable by MoLow · Pull Request #47394 · nodejs/node

Conversation

MoLow commented Apr 3, 2023

Copy link

Copy Markdown

Member

Fixes: #47393

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction

nodejs-github-bot commented Apr 3, 2023

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/test_runner

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added dont-land-on-v14.x needs-ci

PRs that need a full CI run.

test_runner Issues and PRs related to the test runner subsystem. labels

Apr 3, 2023

cjihrig approved these changes

Apr 3, 2023

View reviewed changes

cjihrig left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - is it possible to add a test for this behavior?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

MoLow commented Apr 3, 2023

Copy link

Copy Markdown

Member Author

LGTM - is it possible to add a test for this behavior?

there is a test, it was flaky :)

cjihrig reacted with confused emoji

All reactions

😕 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Apr 4, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

There was an error while loading. Please reload this page.

deokjinkim commented Apr 4, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

@MoLow Commit title has typo(avilable => available).

MoLow reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MoLow commented Apr 4, 2023

Copy link

Copy Markdown

Member Author

@MoLow Commit title has typo(avilable => available).

thanks, I will amend when landing

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Apr 4, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50913/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

anonrig added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label

Apr 4, 2023

github-actions Bot commented Apr 4, 2023

Copy link

Copy Markdown

Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

anonrig, Trott, and GeoffreyBooth reacted with thumbs up emoji

All reactions

👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

anonrig approved these changes

Apr 4, 2023

View reviewed changes

anonrig added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Apr 4, 2023

Trott approved these changes

Apr 4, 2023

View reviewed changes

MoLow added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels

Apr 4, 2023


          test_runner: color errors only when colors are available

7ec93fb

PR-URL: nodejs#47394
Fixes: nodejs#47393
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label

Apr 4, 2023

MoLow force-pushed the fix-spec-reporter-fluke branch from d61c703 to 7ec93fb Compare

April 4, 2023 16:01

MoLow commented Apr 4, 2023

Copy link

Copy Markdown

Member Author

Landed in 7ec93fb

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Trott removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Apr 4, 2023

MoLow merged commit 7ec93fb into nodejs:main

Apr 4, 2023

MoLow deleted the fix-spec-reporter-fluke branch

April 4, 2023 16:01

github-actions Bot mentioned this pull request

Apr 5, 2023

CI Reliability 2023-04-05 nodejs/reliability#540

Open

26 tasks

RafaelGSS pushed a commit that referenced this pull request

Apr 5, 2023


          test_runner: color errors only when colors are available

d7bd288

PR-URL: #47394
Fixes: #47393
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

RafaelGSS mentioned this pull request

Apr 6, 2023

v19.9.0 proposal #47441

Merged

RafaelGSS pushed a commit that referenced this pull request

Apr 6, 2023


          test_runner: color errors only when colors are available

120dc25

PR-URL: #47394
Fixes: #47393
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

RafaelGSS pushed a commit that referenced this pull request

Apr 7, 2023


          test_runner: color errors only when colors are available

9c1f7b6

PR-URL: #47394
Fixes: #47393
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

RafaelGSS pushed a commit that referenced this pull request

Apr 8, 2023


          test_runner: color errors only when colors are available

bc6511a

PR-URL: #47394
Fixes: #47393
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

RafaelGSS pushed a commit that referenced this pull request

Apr 13, 2023


          test_runner: color errors only when colors are available

401d7b1

PR-URL: #47394
Fixes: #47393
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

danielleadams pushed a commit that referenced this pull request

Jul 6, 2023


          test_runner: color errors only when colors are available

ad81687

PR-URL: #47394
Fixes: #47393
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

MoLow added a commit to MoLow/node that referenced this pull request

Jul 6, 2023


          test_runner: color errors only when colors are available

0b32a8c

PR-URL: nodejs#47394
Fixes: nodejs#47393
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

danielleadams mentioned this pull request

Jul 10, 2023

v18.17.0 release proposal #48694

Merged

Reviewers

Trott

Trott approved these changes

anonrig

anonrig approved these changes

cjihrig

cjihrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

fast-track

PRs proposed for a shorter-than-standard waiting period before landing.

needs-ci

PRs that need a full CI run.

test_runner

Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test message/test_runner_output_spec_reporter is flaky

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

MoLow commented Apr 3, 2023

Uh oh!

nodejs-github-bot commented Apr 3, 2023

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

MoLow commented Apr 3, 2023

Uh oh!

nodejs-github-bot commented Apr 4, 2023

Uh oh!

nodejs-github-bot commented Apr 4, 2023

Uh oh!

nodejs-github-bot commented Apr 4, 2023

Uh oh!

nodejs-github-bot commented Apr 4, 2023

Uh oh!

nodejs-github-bot commented Apr 4, 2023

Uh oh!

deokjinkim commented Apr 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MoLow commented Apr 4, 2023

Uh oh!

nodejs-github-bot commented Apr 4, 2023

Uh oh!

github-actions Bot commented Apr 4, 2023

Uh oh!

MoLow commented Apr 4, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

deokjinkim commented Apr 4, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.