GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: mark test/parallel/test-file-write-stream4 as flaky by anonrig · Pull Request #47423 · nodejs/node

Conversation

@anonrig

@anonrig anonrig commented Apr 5, 2023

Copy link
Copy Markdown
Member

a mitigation for #47420

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Apr 5, 2023
VoltrexKeyva
VoltrexKeyva approved these changes Apr 5, 2023
View reviewed changes
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Apr 5, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50974/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
anonrig requested a review from richardlau April 5, 2023 16:25
@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50988/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau reviewed Apr 5, 2023
View reviewed changes
Comment thread test/parallel/parallel.status Resolved

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
anonrig force-pushed the test-file-write-flaky branch from 4db3e4d to 1ff9fec Compare April 5, 2023 21:29
@anonrig
anonrig requested a review from richardlau April 5, 2023 21:29
@anonrig
test: mark test/parallel/test-file-write-stream4 as flaky
2b6588d
@anonrig
anonrig force-pushed the test-file-write-flaky branch from 1ff9fec to 2b6588d Compare April 5, 2023 21:30
richardlau
richardlau approved these changes Apr 5, 2023
View reviewed changes
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
gengjiawen
gengjiawen approved these changes Apr 6, 2023
View reviewed changes
@gengjiawen gengjiawen added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Apr 6, 2023
@github-actions

github-actions Bot commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @gengjiawen. Please 👍 to approve.
VoltrexKeyva and anonrig reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 6, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50995/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Apr 6, 2023

Copy link
Copy Markdown
Member

#47450 should make this unnecessary.
MoLow reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig

anonrig commented Apr 7, 2023

Copy link
Copy Markdown
Member Author

The Github Workflow results are buggy again. Can someone land this manually?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow

MoLow commented Apr 7, 2023

Copy link
Copy Markdown
Member

@anonrig you can land manually as well. Run git node land 47423
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51054/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51071/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51081/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51090/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Apr 10, 2023
View reviewed changes
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 10, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 08e1564 into nodejs:main Apr 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in 08e1564
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS mentioned this pull request Apr 11, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
This was referenced Apr 12, 2023
CI Reliability 2023-04-12 nodejs/reliability#541
Open
CI Reliability 2023-04-13 nodejs/reliability#542
Open
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
@anonrig @RafaelGSS
test: mark test/parallel/test-file-write-stream4 as flaky
a5a5d2f 
PR-URL: #47423
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@anonrig @danielleadams
test: mark test/parallel/test-file-write-stream4 as flaky
17b5999 
PR-URL: #47423
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@anonrig @MoLow
test: mark test/parallel/test-file-write-stream4 as flaky
914f68d 
PR-URL: nodejs#47423
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
@richardlau richardlau richardlau approved these changes
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@anonrig @nodejs-github-bot @targos @MoLow @Trott @gengjiawen @richardlau @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.