GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add ESM examples in http.md by btea · Pull Request #47763 · nodejs/node

Conversation

@btea

@btea btea commented Apr 28, 2023

Copy link
Copy Markdown
Contributor

http module example code update.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Apr 28, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. http Issues and PRs related to the http subsystem. labels Apr 28, 2023
@btea
btea force-pushed the docs/http-mjs branch from 581e2f1 to 4729fec Compare April 28, 2023 11:31
@btea btea changed the title docs: example code add mjs code doc: example code add mjs code Apr 28, 2023
@tniessen

tniessen commented May 2, 2023

Copy link
Copy Markdown
Member

cc @nodejs/documentation @nodejs/modules
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen tniessen added the review wanted PRs that need review. label May 2, 2023
lpinca
lpinca approved these changes Aug 8, 2023
View reviewed changes
@lpinca

lpinca commented Aug 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@btea can you please amend the first commit message and make it start with an imperative verb? Something like "doc: add ESM examples in http.md" should work.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
btea added 2 commits August 9, 2023 07:36
@btea
doc: add ESM examples in http.md
6038092
@btea
chore: import global module
f1e5b01
@btea
btea force-pushed the docs/http-mjs branch from f2c8afa to f1e5b01 Compare August 8, 2023 23:38
@btea btea changed the title doc: example code add mjs code doc: add ESM examples in http.md Aug 8, 2023
@btea

btea commented Aug 8, 2023

Copy link
Copy Markdown
Contributor Author

@btea can you please amend the first commit message and make it start with an imperative verb? Something like "doc: add ESM examples in http.md" should work.

Thanks for the tip, I have updated the message,
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
guybedford
guybedford reviewed Aug 9, 2023
View reviewed changes
Comment thread doc/api/http.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/http.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/http.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@btea
chore: update code
f26a6b9
lpinca pushed a commit that referenced this pull request Aug 10, 2023
@btea @lpinca
doc: add ESM examples in http.md
48c613e 
PR-URL: #47763
Reviewed-By: Luigi Pinca <[email protected]>
@lpinca

lpinca commented Aug 10, 2023

Copy link
Copy Markdown
Member

Landed in 48c613e.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca closed this Aug 10, 2023
@btea
btea deleted the docs/http-mjs branch August 10, 2023 12:58
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@btea @Ceres6
doc: add ESM examples in http.md
658c17b 
PR-URL: nodejs#47763
Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@btea @Ceres6
doc: add ESM examples in http.md
a2c7547 
PR-URL: nodejs#47763
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@btea @RafaelGSS
doc: add ESM examples in http.md
48229a7 
PR-URL: #47763
Reviewed-By: Luigi Pinca <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
v20.6.0 proposal #49185
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@btea @RafaelGSS
doc: add ESM examples in http.md
29de91a 
PR-URL: nodejs#47763
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@btea @RafaelGSS
doc: add ESM examples in http.md
7e7b554 
PR-URL: #47763
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2023
@btea @targos
doc: add ESM examples in http.md
6daa9ec 
PR-URL: #47763
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: add ESM examples in http.md
3d9a481 
PR-URL: nodejs/node#47763
Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: add ESM examples in http.md
c572105 
PR-URL: nodejs/node#47763
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guybedford guybedford guybedford left review comments
@lpinca lpinca lpinca approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. http Issues and PRs related to the http subsystem. review wanted PRs that need review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@btea @nodejs-github-bot @tniessen @lpinca @guybedford
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.