GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: clarify fs permissions only affect fs module by tniessen · Pull Request #47782 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Apr 29, 2023

Copy link
Copy Markdown
Member

As far as I can tell, the permission model implementation currently does not restrict all file system operations but only those through the fs module. WASI, for example, bypasses the permission model entirely.

That appears to be by design, see #44004 (comment).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@tniessen
doc: clarify fs permissions only affect fs module
206ea4c
As far as I can tell, the permission model implementation currently
does not restrict all file system operations but only those through
the fs module. WASI, for example, bypasses the permission model
entirely.
@tniessen tniessen added doc Issues and PRs related to Node.js documentation. security Issues and PRs related to security. labels Apr 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 29, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS
RafaelGSS approved these changes Apr 29, 2023
View reviewed changes

@RafaelGSS RafaelGSS left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@tniessen tniessen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 29, 2023
lpinca
lpinca approved these changes Apr 29, 2023
View reviewed changes
marco-ippolito
marco-ippolito approved these changes Apr 29, 2023
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 1, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 3a3672b into nodejs:main May 1, 2023
@nodejs-github-bot

nodejs-github-bot commented May 1, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3a3672b

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos pushed a commit that referenced this pull request May 2, 2023
@tniessen @targos
doc: clarify fs permissions only affect fs module
72f7297
As far as I can tell, the permission model implementation currently
does not restrict all file system operations but only those through
the fs module. WASI, for example, bypasses the permission model
entirely.

PR-URL: #47782
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@targos targos mentioned this pull request May 2, 2023
v20.1.0 release proposal #47820
Merged
targos pushed a commit that referenced this pull request May 3, 2023
@tniessen @targos
doc: clarify fs permissions only affect fs module
98603b6
As far as I can tell, the permission model implementation currently
does not restrict all file system operations but only those through
the fs module. WASI, for example, bypasses the permission model
entirely.

PR-URL: #47782
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@danielleadams danielleadams added the dont-land-on-v18.x label Jun 29, 2023
@tniessen tniessen added the permission Issues and PRs related to the Permission Model. label Aug 10, 2023
@RafaelGSS RafaelGSS mentioned this pull request May 23, 2024
src,permission: disable WASI when pm is enabled #53124
Merged
@tniessen tniessen mentioned this pull request Aug 8, 2024
doc: explicitly mention node:fs module restriction #54269
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. permission Issues and PRs related to the Permission Model. security Issues and PRs related to security.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@tniessen @nodejs-github-bot @lpinca @RafaelGSS @marco-ippolito @danielleadams @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.