GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: add loong64 config into openssl gypi by shipujin · Pull Request #48043 · nodejs/node

Conversation

@shipujin

@shipujin shipujin commented May 17, 2023

Copy link
Copy Markdown
Member

add loong64 config into openssl

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented May 17, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
shipujin reacted with hooray emoji shipujin reacted with rocket emoji
All reactions
  • 🎉 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. labels May 17, 2023
@shipujin
deps: add loong64 config into openssl gypi
354c41d
@shipujin
shipujin force-pushed the loong64-dev branch from 870fff2 to 354c41d Compare June 9, 2023 01:15
@shipujin

shipujin commented Jun 9, 2023

Copy link
Copy Markdown
Member Author

Update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson

mhdawson commented Jun 12, 2023

Copy link
Copy Markdown
Member

@shipujin I assume that the only non-generated changes that are the ones in the gypi files?
shipujin reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson

mhdawson commented Jun 12, 2023

Copy link
Copy Markdown
Member

I guess that last question did not make sense if all of the .h files are also manually updated which I think is now the case.

It this just what is missing to get loong64 working. I already see that there are filex in - https://github.com/nodejs/node/tree/main/deps/openssl/config/archs/linux64-loongarch64/no-asm
shipujin reacted with thumbs up emoji shipujin reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shipujin

shipujin commented Jun 13, 2023

Copy link
Copy Markdown
Member Author

@shipujin I assume that the only non-generated changes that are the ones in the gypi files?

Yes, once the *gypi file is modified , nodejs can be built using openssl-no-asm in the loong64 environment.

thx~
shipujin reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shipujin

shipujin commented Jun 13, 2023

Copy link
Copy Markdown
Member Author

I guess that last question did not make sense if all of the .h files are also manually updated which I think is now the case.

It this just what is missing to get loong64 working. I already see that there are filex in - https://github.com/nodejs/node/tree/main/deps/openssl/config/archs/linux64-loongarch64/no-asm

Yes

thx~
shipujin reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 28, 2023
mhdawson
mhdawson approved these changes Jun 28, 2023
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shipujin reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52546/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jun 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52559/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson pushed a commit that referenced this pull request Jun 29, 2023
@shipujin @mhdawson
deps: add loong64 config into openssl gypi
9664e66 
PR-URL: #48043
Reviewed-By: Michael Dawson <[email protected]>
@mhdawson

mhdawson commented Jun 29, 2023

Copy link
Copy Markdown
Member

Landed in 9664e66
shipujin reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson closed this Jun 29, 2023
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@shipujin @RafaelGSS
deps: add loong64 config into openssl gypi
1b2b930 
PR-URL: #48043
Reviewed-By: Michael Dawson <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@shipujin @Ceres6
deps: add loong64 config into openssl gypi
ccf91af 
PR-URL: nodejs#48043
Reviewed-By: Michael Dawson <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@shipujin @Ceres6
deps: add loong64 config into openssl gypi
b22318c 
PR-URL: nodejs#48043
Reviewed-By: Michael Dawson <[email protected]>
@shipujin shipujin mentioned this pull request Aug 16, 2023
[v18.x backport] deps: add loong64 config into openssl gypi #49192
Closed
ruyadorno pushed a commit that referenced this pull request Sep 1, 2023
Shi Pujin @ruyadorno
deps: add loong64 config into openssl gypi
3be5335 
Backport-PR-URL: #49192
PR-URL: #48043
Reviewed-By: Michael Dawson [email protected]
@ruyadorno ruyadorno mentioned this pull request Sep 1, 2023
v18.18.0 proposal #49220
Merged
@ruyadorno ruyadorno added the backported-to-v18.x label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@shipujin @nodejs-github-bot @mhdawson @ruyadorno
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.