GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix flaky test-watch-mode by MoLow · Pull Request #48147 · nodejs/node

Conversation

@MoLow

@MoLow MoLow commented May 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes: #44898

stress tests: https://ci.nodejs.org/view/Stress/job/node-stress-single-test/402/

also, ran python tools/test.py -J --repeat=500 test/sequential/test-watch-mode locally (macos m1 & windows vm with arm) with no failures

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels May 23, 2023
@MoLow MoLow added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label May 23, 2023
@MoLow
MoLow force-pushed the fix-flaky-test-watch-mode branch 5 times, most recently from fee6ffb to 155d3a0 Compare May 24, 2023 22:38
@MoLow
MoLow marked this pull request as ready for review May 24, 2023 22:44
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 25, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 25, 2023
@nodejs-github-bot

nodejs-github-bot commented May 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51961/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced May 26, 2023
CI Reliability 2023-05-26 nodejs/reliability#577
Open
CI Reliability 2023-05-27 nodejs/reliability#578
Open
CI Reliability 2023-05-28 nodejs/reliability#579
Open
CI Reliability 2023-05-29 nodejs/reliability#580
Open
CI Reliability 2023-05-30 nodejs/reliability#581
Open
CI Reliability 2023-05-31 nodejs/reliability#582
Open
This was referenced Jun 2, 2023
CI Reliability 2023-06-02 nodejs/reliability#583
Open
CI Reliability 2023-06-03 nodejs/reliability#584
Open
@MoLow
MoLow force-pushed the fix-flaky-test-watch-mode branch from 155d3a0 to 3dfe3ce Compare June 7, 2023 20:37
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 7, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52151/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow marked this pull request as draft June 8, 2023 04:56
@MoLow
MoLow force-pushed the fix-flaky-test-watch-mode branch 3 times, most recently from c968d3d to d68b680 Compare June 8, 2023 05:46
@MoLow
test: fix flaky test-watch-mode
078afb8
@MoLow
MoLow force-pushed the fix-flaky-test-watch-mode branch from d68b680 to 078afb8 Compare June 8, 2023 06:15
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 8, 2023
@MoLow
MoLow marked this pull request as ready for review June 8, 2023 06:20
@nodejs-github-bot

nodejs-github-bot commented Jun 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52153/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jun 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52156/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Jun 8, 2023
View reviewed changes
@MoLow MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 8, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 8, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 9dc2d1b into nodejs:main Jun 8, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 8, 2023

Copy link
Copy Markdown
Collaborator

Landed in 9dc2d1b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow deleted the fix-flaky-test-watch-mode branch June 8, 2023 11:38
This was referenced Jun 11, 2023
CI Reliability 2023-06-11 nodejs/reliability#590
Open
CI Reliability 2023-06-12 nodejs/reliability#591
Open
CI Reliability 2023-06-13 nodejs/reliability#592
Open
CI Reliability 2023-06-14 nodejs/reliability#593
Open
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@MoLow @RafaelGSS
test: fix flaky test-watch-mode
7c790ca 
PR-URL: #48147
Fixes: #44898
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test: fix flaky test-watch-mode
7694e1f 
PR-URL: nodejs#48147
Fixes: nodejs#44898
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test: fix flaky test-watch-mode
ae0d008 
PR-URL: nodejs#48147
Fixes: nodejs#44898
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@ruyadorno

ruyadorno commented Aug 29, 2023

Copy link
Copy Markdown
Member

hi @MoLow this is not landing cleanly in v18.x-staging and will need manual backporting.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ruyadorno ruyadorno added the backport-requested-v18.x label Aug 29, 2023
@MoLow MoLow added backport-open-v18.x and removed backport-requested-v18.x labels Sep 3, 2023
ruyadorno pushed a commit to MoLow/node that referenced this pull request Sep 7, 2023
@MoLow @ruyadorno
test: fix flaky test-watch-mode
35943c1 
PR-URL: nodejs#48147
Fixes: nodejs#44898
Reviewed-By: Benjamin Gruenbaum <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 7, 2023
@MoLow @ruyadorno
test: fix flaky test-watch-mode
4892dc5 
PR-URL: #48147
Backport-PR-URL: #49468
Fixes: #44898
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 8, 2023
v18.18.0 proposal #49220
Merged
@ruyadorno ruyadorno added backported-to-v18.x and removed backport-open-v18.x labels Sep 9, 2023
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@MoLow @ruyadorno
test: fix flaky test-watch-mode
9d90409 
PR-URL: #48147
Backport-PR-URL: #49468
Fixes: #44898
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky test-watch-mode (no. 3)

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@MoLow @nodejs-github-bot @ruyadorno @benjamingr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.