GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — stream: remove asIndexedPairs by atlowChemi · Pull Request #48150 · nodejs/node

Conversation

@atlowChemi

@atlowChemi atlowChemi commented May 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Refs: #48102 (review), tc39/proposal-iterator-helpers@bdb4883

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented May 24, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 24, 2023
@atlowChemi

atlowChemi commented May 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@aduh95 @benjamingr as discussed in #48102 (review) this should have the dont-land-on-20.x label 🙂
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow added dont-land-on-v20.x labels May 24, 2023
aduh95
aduh95 approved these changes May 24, 2023
View reviewed changes
Comment thread doc/api/stream.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes May 24, 2023
View reviewed changes
@benjamingr benjamingr added the blocked PRs that are blocked by other issues or PRs. label May 24, 2023
@atlowChemi atlowChemi added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed blocked PRs that are blocked by other issues or PRs. labels Jun 8, 2023
@aduh95 aduh95 removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jun 8, 2023
@atlowChemi
stream: remove asIndexedPairs
448c208
@atlowChemi
atlowChemi force-pushed the remove-asIndexedPairs branch from b2dae8d to 448c208 Compare June 13, 2023 07:28
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 13, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52234/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52236/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Jun 13, 2023
View reviewed changes
@aduh95 aduh95 added experimental Issues and PRs related to experimental features. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Jun 13, 2023
@atlowChemi atlowChemi added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 13, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 13, 2023
@nodejs-github-bot
nodejs-github-bot merged commit d4e99b1 into nodejs:main Jun 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2023

Copy link
Copy Markdown
Collaborator

Landed in d4e99b1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@atlowChemi
atlowChemi deleted the remove-asIndexedPairs branch June 13, 2023 12:55
This was referenced Jun 14, 2023
CI Reliability 2023-06-14 nodejs/reliability#593
Open
CI Reliability 2023-06-15 nodejs/reliability#594
Open
@github-actions github-actions Bot mentioned this pull request Jun 21, 2023
CI Reliability 2023-06-21 nodejs/reliability#595
Open
29 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
stream: remove asIndexedPairs
f8ed71b 
PR-URL: nodejs#48150
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
stream: remove asIndexedPairs
24be3c4 
PR-URL: nodejs#48150
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@atlowChemi @nodejs-github-bot @benjamingr @aduh95 @MoLow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.