GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — doc: update fs.realpath documentation by sinkhaha · Pull Request #48170 · nodejs/node

Conversation

sinkhaha commented May 25, 2023

Copy link

Copy Markdown

Contributor

Fixes: #45067

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction


          doc: update fs.realpath documentation

77d54fe

nodejs-github-bot added doc

Issues and PRs related to Node.js documentation.

fs Issues and PRs related to file-system APIs and the fs module. labels

May 25, 2023

bnoordhuis reviewed

May 27, 2023

View reviewed changes

Comment thread

doc/api/fs.md Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update doc/api/fs.md

fbb0d61

Co-authored-by: Ben Noordhuis <[email protected]>

Trott added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label

May 27, 2023

jasnell approved these changes

May 29, 2023

View reviewed changes

aymen94 approved these changes

Jun 6, 2023

View reviewed changes

lpinca previously approved these changes

Jun 17, 2023

View reviewed changes

Comment thread

doc/api/fs.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lpinca dismissed their stale review

June 17, 2023 19:15

It does not seem to document the difference noted in #45067


          doc: remove space

ce01b43

sinkhaha requested review from bnoordhuis and lpinca

June 19, 2023 09:40

sinkhaha commented Jul 11, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

If you have time, could you please handle this PR, thanks @bnoordhuis @lpinca @jasnell @aymen94

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell added commit-queue

PRs queued for automated landing through the Commit Queue.

commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels

Mar 24, 2024

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels

Mar 24, 2024

nodejs-github-bot commented Mar 24, 2024

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/48170
✔  Done loading data for nodejs/node/pull/48170
----------------------------------- PR info ------------------------------------
Title      doc: update fs.realpath documentation (#48170)
Author     sinkhaha <[email protected]> (@sinkhaha)
Branch     sinkhaha:update-doc-path-realpath -> nodejs:main
Labels     doc, fs, commit-queue-squash
Commits    3
 - doc: update fs.realpath documentation
 - Update doc/api/fs.md
 - doc: remove space
Committers 2
 - sinkhaha <[email protected]>
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/48170
Fixes: https://github.com/nodejs/node/issues/45067
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48170
Fixes: https://github.com/nodejs/node/issues/45067
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - doc: remove space
   ℹ  This PR was created on Thu, 25 May 2023 09:00:56 GMT
   ✔  Approvals: 1
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/48170#pullrequestreview-1449797964
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/8410404883

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 merged commit c4d0229 into nodejs:main

May 11, 2024

aduh95 commented May 11, 2024

Copy link

Copy Markdown

Contributor

Landed in c4d0229

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos pushed a commit that referenced this pull request

May 11, 2024


          doc: update fs.realpath documentation

a6d624c

PR-URL: #48170
Fixes: #45067
Reviewed-By: James M Snell <[email protected]>

targos mentioned this pull request

May 13, 2024

v22.2.0 release proposal #52971

Merged

marco-ippolito mentioned this pull request

Jun 17, 2024

v20.15.0 proposal #53486

Merged

marco-ippolito pushed a commit that referenced this pull request

Jun 17, 2024


          doc: update fs.realpath documentation

585f2a2

PR-URL: #48170
Fixes: #45067
Reviewed-By: James M Snell <[email protected]>

soophoo pushed a commit to soophoo/node that referenced this pull request

Jun 20, 2024


          doc: update fs.realpath documentation

e359bee

PR-URL: nodejs#48170
Fixes: nodejs#45067
Reviewed-By: James M Snell <[email protected]>

ClassicOldSong commented Jun 10, 2026

Copy link

Copy Markdown

The difference is still not documented and that's pretty confusing.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

jasnell

jasnell approved these changes

bnoordhuis

Awaiting requested review from bnoordhuis

lpinca

Awaiting requested review from lpinca

+1 more reviewer

aymen94

aymen94 approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-failed

PRs whose Commit Queue landing failed and need manual intervention before retrying.

commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

doc

Issues and PRs related to Node.js documentation.

Issues and PRs related to file-system APIs and the fs module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fs.realpath vs fs.realpath.native differences not documented

Uh oh!

There was an error while loading. Please reload this page.

9 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

sinkhaha commented May 25, 2023

Uh oh!

Uh oh!

Uh oh!

sinkhaha commented Jul 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 24, 2024

Uh oh!

aduh95 commented May 11, 2024

Uh oh!

ClassicOldSong commented Jun 10, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

sinkhaha commented Jul 11, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.