GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: update action to close stale PRs by mhdawson · Pull Request #48196 · nodejs/node

Conversation

@mhdawson

@mhdawson mhdawson commented May 26, 2023

Copy link
Copy Markdown
Member

My original plan of adding a lable to limit those initially process as outlined in #48051 does not work I think because adding a lable updates the last update time.

  • Removing the need for the lable
  • Remove the cron scheduling so that it only runs when I run it manually
  • Fix the display name for the action as I missed updating that after cut and paste from existing action

The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mhdawson
build: update action to close stale PRs
2d6b1eb
My original plan of adding a lable to limit those initially
process as outlined in nodejs#48051
does not work I think because adding a lable updates the last
update time.

- Removing the need for the lable
- Remove the cron scheduling so that it only runs when I run it manually
- Fix the display name for the action as I missed updating that after
  cut and paste from existing action

The plan will be to find stop dates that should only affect a reasonable
number of PRs at a time and then run in batches using that instead.

Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented May 26, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 26, 2023
Mesteery
Mesteery approved these changes May 27, 2023
View reviewed changes
mhdawson added a commit that referenced this pull request Jun 5, 2023
@mhdawson
build: update action to close stale PRs
41f8abc
My original plan of adding a lable to limit those initially
process as outlined in #48051
does not work I think because adding a lable updates the last
update time.

- Removing the need for the lable
- Remove the cron scheduling so that it only runs when I run it manually
- Fix the display name for the action as I missed updating that after
  cut and paste from existing action

The plan will be to find stop dates that should only affect a reasonable
number of PRs at a time and then run in batches using that instead.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #48196
Reviewed-By: Mestery <[email protected]>
@mhdawson

mhdawson commented Jun 5, 2023

Copy link
Copy Markdown
Member Author

Landed in 41f8abc

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Mesteery Mesteery added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jun 5, 2023
@Mesteery Mesteery closed this Jun 5, 2023
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@mhdawson @RafaelGSS
build: update action to close stale PRs
f60205c
My original plan of adding a lable to limit those initially
process as outlined in #48051
does not work I think because adding a lable updates the last
update time.

- Removing the need for the lable
- Remove the cron scheduling so that it only runs when I run it manually
- Fix the display name for the action as I missed updating that after
  cut and paste from existing action

The plan will be to find stop dates that should only affect a reasonable
number of PRs at a time and then run in batches using that instead.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #48196
Reviewed-By: Mestery <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@mhdawson @Ceres6
build: update action to close stale PRs
d7750ed
My original plan of adding a lable to limit those initially
process as outlined in nodejs#48051
does not work I think because adding a lable updates the last
update time.

- Removing the need for the lable
- Remove the cron scheduling so that it only runs when I run it manually
- Fix the display name for the action as I missed updating that after
  cut and paste from existing action

The plan will be to find stop dates that should only affect a reasonable
number of PRs at a time and then run in batches using that instead.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: nodejs#48196
Reviewed-By: Mestery <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@mhdawson @Ceres6
build: update action to close stale PRs
24bcda4
My original plan of adding a lable to limit those initially
process as outlined in nodejs#48051
does not work I think because adding a lable updates the last
update time.

- Removing the need for the lable
- Remove the cron scheduling so that it only runs when I run it manually
- Fix the display name for the action as I missed updating that after
  cut and paste from existing action

The plan will be to find stop dates that should only affect a reasonable
number of PRs at a time and then run in batches using that instead.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: nodejs#48196
Reviewed-By: Mestery <[email protected]>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
@mhdawson @ruyadorno
build: update action to close stale PRs
211a4f8
My original plan of adding a lable to limit those initially
process as outlined in #48051
does not work I think because adding a lable updates the last
update time.

- Removing the need for the lable
- Remove the cron scheduling so that it only runs when I run it manually
- Fix the display name for the action as I missed updating that after
  cut and paste from existing action

The plan will be to find stop dates that should only affect a reasonable
number of PRs at a time and then run in batches using that instead.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #48196
Reviewed-By: Mestery <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Aug 29, 2023
v18.18.0 proposal #49220
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Mesteery Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mhdawson @nodejs-github-bot @Mesteery
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.