GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — quic: next iteration by jasnell · Pull Request #48244 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented May 29, 2023

Copy link
Copy Markdown
Member

Adds the basic implementation of the quic stream. Still more to come.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss, tonivj5, espoal, nicolashenry, wemeetagain, and Qard reacted with eyes emoji
All reactions
  • 👀 6 reactions
@jasnell
jasnell requested review from Qard, anonrig and tniessen May 29, 2023 18:21
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels May 29, 2023
@jasnell
jasnell force-pushed the quic-part-7 branch from b6ba7a4 to 4bdb924 Compare May 29, 2023 18:27
anonrig
anonrig reviewed May 29, 2023
View reviewed changes
Comment thread src/dataqueue/queue.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/dataqueue/queue.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/quic/streams.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/quic/streams.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/quic/streams.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/quic/streams.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/quic/streams.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/quic/streams.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/quic/streams.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/quic/streams.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
@achingbrain achingbrain mentioned this pull request May 30, 2023
Add support for QUIC libp2p/js-libp2p#1459
Open
anonrig
anonrig approved these changes May 31, 2023
View reviewed changes
Qard
Qard approved these changes Jun 1, 2023
View reviewed changes
Qard
Qard reviewed Jun 1, 2023
View reviewed changes
Comment thread src/quic/streams.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added author ready PRs with CI started, the required approvals, and no outstanding review comments. quic Issues and PRs related to the QUIC transport implementation. dont-land-on-v16.x labels Jun 3, 2023
@targos targos removed the dont-land-on-v19.x label Jun 4, 2023
Qard
Qard approved these changes Jun 5, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Jun 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52117/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jun 6, 2023
CI Reliability 2023-06-06 nodejs/reliability#587
Open
CI Reliability 2023-06-09 nodejs/reliability#588
Open
CI Reliability 2023-06-10 nodejs/reliability#589
Open
@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52192/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jun 11, 2023
CI Reliability 2023-06-11 nodejs/reliability#590
Open
CI Reliability 2023-06-12 nodejs/reliability#591
Open
CI Reliability 2023-06-13 nodejs/reliability#592
Open
CI Reliability 2023-06-14 nodejs/reliability#593
Open
CI Reliability 2023-06-15 nodejs/reliability#594
Open
This was referenced Sep 19, 2023
CI Reliability 2023-09-19 nodejs/reliability#670
Open
CI Reliability 2023-09-20 nodejs/reliability#671
Open
@targos targos removed the dont-land-on-v16.x label Sep 27, 2023
@achingbrain achingbrain mentioned this pull request Oct 1, 2023
webrtc(private-to-private): clarify interaction with DCUtR libp2p/specs#583
Closed
jasnell added 7 commits December 9, 2023 10:31
@jasnell
quic: add backpressure notification to dataqueue
74eb03d
@jasnell
quic: add streams implementation
8f3b1e4
@jasnell
quic: address review comments
50cf6c5
@jasnell
quic: address review comments
43acc5f
@jasnell
quic: address review comments
d8fe4e7
@jasnell
quic: fix cpp formatting
fc7da04
@jasnell
quic: fixup mac build issue
7ca1bfb
@jasnell
jasnell force-pushed the quic-part-7 branch from 351eded to 918abb9 Compare December 9, 2023 18:49
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
anonrig
anonrig approved these changes Dec 9, 2023
View reviewed changes
@jasnell
quic: address review comments
81a31c6
@jasnell
jasnell force-pushed the quic-part-7 branch from 918abb9 to 81a31c6 Compare December 9, 2023 20:07
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@anonrig anonrig added commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Dec 9, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2023 •
edited by jasnell
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56214/ 💚
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell added a commit that referenced this pull request Dec 11, 2023
@jasnell
quic: further implementation details
fc102f2 
PR-URL: #48244
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
@jasnell

jasnell commented Dec 11, 2023

Copy link
Copy Markdown
Member Author

Landed in fc102f2
Qard and controversial reacted with hooray emoji Qard and controversial reacted with rocket emoji
All reactions
  • 🎉 2 reactions
  • 🚀 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Dec 11, 2023
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@jasnell @RafaelGSS
quic: further implementation details
3fb7fc9 
PR-URL: #48244
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
v21.5.0 proposal #51166
Merged
@robertsLando robertsLando mentioned this pull request Aug 8, 2024
feat: add quic support mqttjs/MQTT.js#1925
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qard Qard Qard approved these changes
@anonrig anonrig anonrig approved these changes
@tniessen tniessen Awaiting requested review from tniessen

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash PRs the Commit Queue should land as one squashed commit. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@jasnell @nodejs-github-bot @anonrig @Qard @targos @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.