GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix `test-net-autoselectfamily` for kernel without IPv6 support by LiviaMedeiros · Pull Request #48265 · nodejs/node

Conversation

@LiviaMedeiros

@LiviaMedeiros LiviaMedeiros commented May 31, 2023

Copy link
Copy Markdown
Member

If CONFIG_IPV6 is disabled, the observed error on some platforms is EAFNOSUPPORT instead of EADDRNOTAVAIL.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@LiviaMedeiros
test: fix test-net-autoselectfamily for kernel without IPv6 support
1ede683
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels May 31, 2023
@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 31, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 31, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52050/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Jun 1, 2023
View reviewed changes
lpinca
lpinca reviewed Jun 1, 2023
View reviewed changes
Comment thread test/parallel/test-net-autoselectfamily-commandline-option.js
assert.strictEqual(error.code, 'ECONNREFUSED');
assert.strictEqual(error.message, `connect ECONNREFUSED ::1:${port}`);
} else if (error.code === 'EAFNOSUPPORT') {
assert.strictEqual(error.message, `connect EAFNOSUPPORT ::1:${port} - Local (undefined:undefined)`);

@lpinca lpinca Jun 1, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That undefined:undefined is a bit weird.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@LiviaMedeiros LiviaMedeiros Jun 1, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it makes sense for systems without IPv6 support to not know how to represent invalid/unknown source [address]:port. 😄
It is possible to adjust all exceptionWithHostPort(..., additional) calls so they will try to provide more descriptive error in this specific case, but not worth it imho.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lpinca
lpinca approved these changes Jun 1, 2023
View reviewed changes
This was referenced Jun 2, 2023
CI Reliability 2023-06-02 nodejs/reliability#583
Open
CI Reliability 2023-06-03 nodejs/reliability#584
Open
CI Reliability 2023-06-04 nodejs/reliability#585
Open
@lpinca lpinca added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Jun 4, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Jun 4, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 4, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/48265
✔  Done loading data for nodejs/node/pull/48265
----------------------------------- PR info ------------------------------------
Title      test: fix `test-net-autoselectfamily` for kernel without IPv6 support (#48265)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     LiviaMedeiros:net-test-asf-cmd-option-noipv6 -> nodejs:main
Labels     test, author ready, needs-ci
Commits    1
 - test: fix `test-net-autoselectfamily` for kernel without IPv6 support
Committers 1
 - LiviaMedeiros 
PR-URL: https://github.com/nodejs/node/pull/48265
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48265
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 31 May 2023 16:13:48 GMT
   ✔  Approvals: 1
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48265#pullrequestreview-1456022547
   ✘  This PR needs to wait 82 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-06-01T12:55:51Z: https://ci.nodejs.org/job/node-test-pull-request/52050/
- Querying data for job/node-test-pull-request/52050/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5167492972
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jun 5, 2023
CI Reliability 2023-06-05 nodejs/reliability#586
Open
CI Reliability 2023-06-06 nodejs/reliability#587
Open
@LiviaMedeiros LiviaMedeiros added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Jun 7, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 7, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 9c5efdd into nodejs:main Jun 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 7, 2023

Copy link
Copy Markdown
Collaborator

Landed in 9c5efdd
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@LiviaMedeiros @RafaelGSS
test: fix test-net-autoselectfamily for kernel without IPv6 support
1398829 
PR-URL: #48265
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@LiviaMedeiros @Ceres6
test: fix test-net-autoselectfamily for kernel without IPv6 support
5c15883 
PR-URL: nodejs#48265
Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@LiviaMedeiros @Ceres6
test: fix test-net-autoselectfamily for kernel without IPv6 support
8d02f56 
PR-URL: nodejs#48265
Reviewed-By: Luigi Pinca <[email protected]>
@ruyadorno

ruyadorno commented Aug 29, 2023

Copy link
Copy Markdown
Member

hi @LiviaMedeiros this commit is not landing cleanly in v18.x-staging and will need manual backporting.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ruyadorno ruyadorno added the backport-requested-v18.x label Aug 29, 2023
@LiviaMedeiros

LiviaMedeiros commented Aug 29, 2023

Copy link
Copy Markdown
Member Author

Sure; I'll open backport PR if https://github.com/nodejs/node/blame/v18.18.0-proposal/test/parallel/test-net-autoselectfamily-commandline-option.js will become affected by this problem and this PR still won't be landable.

Right now affected test seem to not rely in EADDRNOTAVAIL in v18.x branch (and there's a chance that the PR that added this test was semver-major) so this PR can be skipped.
ruyadorno reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@LiviaMedeiros @nodejs-github-bot @ruyadorno @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.