GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add additional info on TSFN dispatch by mhdawson · Pull Request #48367 · nodejs/node

Conversation

@mhdawson

@mhdawson mhdawson commented Jun 6, 2023

Copy link
Copy Markdown
Member

Refs: #48356

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@mhdawson
doc: add additional info on TSFN dispatch
08bd4b4 
Refs: nodejs#48356

Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Jun 6, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/node-api
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. node-api Issues and PRs related to Node-API. labels Jun 6, 2023
@mhdawson

mhdawson commented Jun 6, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Implementation of dispatch is here:

node/src/node_api.cc

Line 350 in a929522

void Dispatch() {

Currently at least 1 and up to 1000 callbacks in the queue will be invoked, but that I believe should be left as an implementation detail. Doc is updated to indicate that more than one can be invoked in tick, but there is no guarantee as to how many will be in any given tick.

@nodejs/node-api does that seem reasonable to everybody?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson mentioned this pull request Jun 6, 2023
TSFN callback queue behavior clarification #48356
Closed
tniessen
tniessen approved these changes Jun 7, 2023
View reviewed changes
legendecas
legendecas reviewed Jun 8, 2023
View reviewed changes
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson @legendecas
Update doc/api/n-api.md
39b665e 
Co-authored-by: Chengzhong Wu <[email protected]>
VoltrexKeyva
VoltrexKeyva reviewed Jun 8, 2023
View reviewed changes
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson @VoltrexKeyva
Update doc/api/n-api.md
668d6e8 
Co-authored-by: Mohammed Keyvanzadeh <[email protected]>
legendecas
legendecas approved these changes Jun 10, 2023
View reviewed changes
mhdawson added a commit that referenced this pull request Jun 12, 2023
@mhdawson
doc: add additional info on TSFN dispatch
1da9099 
Refs: #48356

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #48367
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@mhdawson

mhdawson commented Jun 12, 2023

Copy link
Copy Markdown
Member Author

Landed in 1da9099
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson closed this Jun 12, 2023
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@mhdawson @RafaelGSS
doc: add additional info on TSFN dispatch
b9c643e 
Refs: #48356

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #48367
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@mhdawson @Ceres6
doc: add additional info on TSFN dispatch
ae3243b 
Refs: nodejs#48356

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: nodejs#48367
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@mhdawson @Ceres6
doc: add additional info on TSFN dispatch
4f242d3 
Refs: nodejs#48356

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: nodejs#48367
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 7, 2023
@mhdawson @ruyadorno
doc: add additional info on TSFN dispatch
a8db331 
Refs: #48356

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #48367
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 8, 2023
v18.18.0 proposal #49220
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@mhdawson @ruyadorno
doc: add additional info on TSFN dispatch
2a561ae 
Refs: #48356

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #48367
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessen tniessen tniessen approved these changes
@legendecas legendecas legendecas approved these changes
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. node-api Issues and PRs related to Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@mhdawson @nodejs-github-bot @tniessen @legendecas @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.