GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: add missing <algorithm> include for std::find by thesamesam · Pull Request #48380 · nodejs/node

Conversation

@thesamesam

@thesamesam thesamesam commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

GCC 14 drops some transitive includes within libstdc++. Explicitly include for std::find.

Signed-off-by: Sam James [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Jun 7, 2023
@thesamesam

thesamesam commented Jun 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Sorry, this is identical to #48330 - I was playing with some github tooling to update local forks and messed it up (and it deleted the fork).

Apologies for the hassle folks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@thesamesam
thesamesam force-pushed the gcc14 branch from bf0e64d to a8b2a25 Compare June 7, 2023 18:07
LiviaMedeiros
LiviaMedeiros approved these changes Jun 7, 2023
View reviewed changes
LiviaMedeiros
LiviaMedeiros reviewed Jun 7, 2023
View reviewed changes
Comment thread test/embedding/embedtest.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
@thesamesam
test: add missing <algorithm> include for std::find
f02cf6f 
GCC 14 drops some transitive includes within libstdc++.

Explicitly include <algorithm> for std::find.

Signed-off-by: Sam James <[email protected]>
@thesamesam
thesamesam force-pushed the gcc14 branch from a8b2a25 to f02cf6f Compare June 7, 2023 19:47
lpinca
lpinca approved these changes Jun 7, 2023
View reviewed changes
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 7, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52150/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
KhafraDev
KhafraDev approved these changes Jun 7, 2023
View reviewed changes
@lpinca lpinca added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jun 8, 2023
@debadree25 debadree25 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Jun 8, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 9, 2023
@nodejs-github-bot
nodejs-github-bot merged commit ad0bbaf into nodejs:main Jun 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2023

Copy link
Copy Markdown
Collaborator

Landed in ad0bbaf
LiviaMedeiros reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@thesamesam
thesamesam deleted the gcc14 branch June 10, 2023 04:48
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@thesamesam @RafaelGSS
test: add missing <algorithm> include for std::find
77cb1ee 
GCC 14 drops some transitive includes within libstdc++.

Explicitly include <algorithm> for std::find.

Signed-off-by: Sam James <[email protected]>
PR-URL: #48380
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@thesamesam @Ceres6
test: add missing <algorithm> include for std::find
115d4df 
GCC 14 drops some transitive includes within libstdc++.

Explicitly include <algorithm> for std::find.

Signed-off-by: Sam James <[email protected]>
PR-URL: nodejs#48380
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@thesamesam @Ceres6
test: add missing <algorithm> include for std::find
2f1654f 
GCC 14 drops some transitive includes within libstdc++.

Explicitly include <algorithm> for std::find.

Signed-off-by: Sam James <[email protected]>
PR-URL: nodejs#48380
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
@thesamesam @ruyadorno
test: add missing <algorithm> include for std::find
23721c2 
GCC 14 drops some transitive includes within libstdc++.

Explicitly include <algorithm> for std::find.

Signed-off-by: Sam James <[email protected]>
PR-URL: #48380
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Aug 29, 2023
v18.18.0 proposal #49220
Merged
ruyadorno pushed a commit that referenced this pull request Sep 1, 2023
@thesamesam @ruyadorno
test: add missing <algorithm> include for std::find
27a4bc7 
GCC 14 drops some transitive includes within libstdc++.

Explicitly include <algorithm> for std::find.

Signed-off-by: Sam James <[email protected]>
PR-URL: #48380
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes
@lpinca lpinca lpinca approved these changes
@KhafraDev KhafraDev KhafraDev approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@thesamesam @nodejs-github-bot @lpinca @KhafraDev @LiviaMedeiros @debadree25
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.