GeezerVison is showing github.com — crypto: remove OPENSSL_FIPS guard for OpenSSL 3 by richardlau · Pull Request #48392 · nodejs/node
Conversation
The OPENSSL_FIPS guard is only needed for versions of OpenSSL earlier than 3.0.
Removing the guard for OpenSSL 3 fixes parallel/test-crypto-fips when run with a FIPS enabled OpenSSL 3 configuration.
Refs: #48379
cc @nodejs/crypto
Test failure on main (9dc2d1b)
13:27:29 not ok 640 parallel/test-crypto-fips
13:27:29 ---
13:27:29 duration_ms: 303.07300
13:27:29 severity: fail
13:27:29 exitcode: 1
13:27:29 stack: |-
13:27:29 Spawned child [pid:2304732] with cmd 'process.versions' expect "OpenSSL error when trying to enable FIPS:" with args '--enable-fips' OPENSSL_CONF="/opt/openssl-3.0.8-fips/ssl/openssl.cnf"
13:27:29 node:assert:125
13:27:29 throw new AssertionError(obj);
13:27:29 ^
13:27:29
13:27:29 AssertionError [ERR_ASSERTION]: Expected "actual" to be strictly unequal to: 0
13:27:29 at responseHandler (/home/iojs/build/workspace/richardlau-node-test-commit-linux-containered/test/parallel/test-crypto-fips.js:48:12)
13:27:29 at testHelper (/home/iojs/build/workspace/richardlau-node-test-commit-linux-containered/test/parallel/test-crypto-fips.js:61:3)
13:27:29 at Object.<anonymous> (/home/iojs/build/workspace/richardlau-node-test-commit-linux-containered/test/parallel/test-crypto-fips.js:65:1)
13:27:29 at Module._compile (node:internal/modules/cjs/loader:1255:14)
13:27:29 at Module._extensions..js (node:internal/modules/cjs/loader:1309:10)
13:27:29 at Module.load (node:internal/modules/cjs/loader:1113:32)
13:27:29 at Module._load (node:internal/modules/cjs/loader:960:12)
13:27:29 at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
13:27:29 at node:internal/main/run_main_module:23:47 {
13:27:29 generatedMessage: true,
13:27:29 code: 'ERR_ASSERTION',
13:27:29 actual: 0,
13:27:29 expected: 0,
13:27:29 operator: 'notStrictEqual'
13:27:29 }
13:27:29
13:27:29 Node.js v21.0.0-pre
13:27:29 ...
Passing with this PR (84a33d6)
15:39:50 ok 638 parallel/test-crypto-fips
15:39:50 ---
15:39:50 duration_ms: 752.46200
15:39:50 ...
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
The OPENSSL_FIPS guard is only needed for versions of OpenSSL earlier
than 3.0.
Removing the guard for OpenSSL 3 fixes `parallel/test-crypto-fips`
when run with a FIPS enabled OpenSSL 3 configuration.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
richardlau
added
request-ci
Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review.
and removed
crypto
Issues and PRs related to the crypto subsystem.
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
Jun 8, 2023
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jun 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jun 13, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
The OPENSSL_FIPS guard is only needed for versions of OpenSSL earlier
than 3.0.
Removing the guard for OpenSSL 3 fixes `parallel/test-crypto-fips`
when run with a FIPS enabled OpenSSL 3 configuration.
PR-URL: #48392
Refs: #48379
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
The OPENSSL_FIPS guard is only needed for versions of OpenSSL earlier
than 3.0.
Removing the guard for OpenSSL 3 fixes `parallel/test-crypto-fips`
when run with a FIPS enabled OpenSSL 3 configuration.
PR-URL: nodejs#48392
Refs: nodejs#48379
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
The OPENSSL_FIPS guard is only needed for versions of OpenSSL earlier
than 3.0.
Removing the guard for OpenSSL 3 fixes `parallel/test-crypto-fips`
when run with a FIPS enabled OpenSSL 3 configuration.
PR-URL: nodejs#48392
Refs: nodejs#48379
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 8, 2023
The OPENSSL_FIPS guard is only needed for versions of OpenSSL earlier
than 3.0.
Removing the guard for OpenSSL 3 fixes `parallel/test-crypto-fips`
when run with a FIPS enabled OpenSSL 3 configuration.
PR-URL: #48392
Refs: #48379
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 13, 2023
The OPENSSL_FIPS guard is only needed for versions of OpenSSL earlier
than 3.0.
Removing the guard for OpenSSL 3 fixes `parallel/test-crypto-fips`
when run with a FIPS enabled OpenSSL 3 configuration.
PR-URL: #48392
Refs: #48379
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewers
lpinca
lpinca approved these changes
+1 more reviewer
mhdawson
mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Labels
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
crypto
Issues and PRs related to the crypto subsystem.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|